From 02c275850f9de7e24e8caa3c514f04e84a349db1 Mon Sep 17 00:00:00 2001 From: Conrad Chan Date: Wed, 16 Feb 2022 18:55:30 +1100 Subject: [PATCH 1/3] fix incorrectly reduced variables --- src/tests/test_nonidealmhd.F90 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tests/test_nonidealmhd.F90 b/src/tests/test_nonidealmhd.F90 index fec8c3527..b2629f375 100644 --- a/src/tests/test_nonidealmhd.F90 +++ b/src/tests/test_nonidealmhd.F90 @@ -498,8 +498,8 @@ subroutine test_standingshock(ntests,npass) endif npts = int(reduceall_mpi('+',npts)) L2d = reduceall_mpi('+',L2d) - L2v = reduceall_mpi('+',L2d) - L2b = reduceall_mpi('+',L2d) + L2v = reduceall_mpi('+',L2v) + L2b = reduceall_mpi('+',L2b) if (npts > 0) then L2d = sqrt(L2d/npts) L2v = sqrt(L2v/npts) From d0224ec5b85a6460261ed2d050ed70cb8f0da884 Mon Sep 17 00:00:00 2001 From: Conrad Chan Date: Wed, 16 Feb 2022 19:27:03 +1100 Subject: [PATCH 2/3] revert tolb to original value --- src/tests/test_nonidealmhd.F90 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/test_nonidealmhd.F90 b/src/tests/test_nonidealmhd.F90 index b2629f375..0c0cd375f 100644 --- a/src/tests/test_nonidealmhd.F90 +++ b/src/tests/test_nonidealmhd.F90 @@ -297,7 +297,7 @@ subroutine test_standingshock(ntests,npass) real :: t,dt,dtext,dtnew real :: dexact,bexact,vexact,L2d,L2v,L2b,dx real :: leftstate(8),rightstate(8),exact_x(51),exact_d(51),exact_vx(51),exact_by(51) - real, parameter :: told = 2.1d-2, tolv=3.1d-2, tolb=3.1d-2 + real, parameter :: told = 2.1d-2, tolv=3.1d-2, tolb=1.e-1 logical :: valid_dt logical, parameter :: print_output = .false. logical :: valid_bdy_rho,valid_bdy_v From 347953089e9e5e81bb02d01ec17d6bdc45848d70 Mon Sep 17 00:00:00 2001 From: Conrad Chan Date: Wed, 16 Feb 2022 19:38:43 +1100 Subject: [PATCH 3/3] amend previous commit tolb should be 1.1d-1 instead of 1.e-1 --- src/tests/test_nonidealmhd.F90 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/test_nonidealmhd.F90 b/src/tests/test_nonidealmhd.F90 index 0c0cd375f..8f9c4f500 100644 --- a/src/tests/test_nonidealmhd.F90 +++ b/src/tests/test_nonidealmhd.F90 @@ -297,7 +297,7 @@ subroutine test_standingshock(ntests,npass) real :: t,dt,dtext,dtnew real :: dexact,bexact,vexact,L2d,L2v,L2b,dx real :: leftstate(8),rightstate(8),exact_x(51),exact_d(51),exact_vx(51),exact_by(51) - real, parameter :: told = 2.1d-2, tolv=3.1d-2, tolb=1.e-1 + real, parameter :: told = 2.1d-2, tolv=3.1d-2, tolb=1.1d-1 logical :: valid_dt logical, parameter :: print_output = .false. logical :: valid_bdy_rho,valid_bdy_v