Keep position on rotation #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve added a flag to BarLineChartViewBase indicating whether the chart should stay at its current position or not The flag defaults to false to not change any existing behaviour.
|
This is a great feature! I'll see how we can migrate this to the Android side and then merge. If you are working on this crossplatform and want to issue a PR there as well - please the PR from the other one so we can synchronize the merge. |
|
@danielgindi I'm looking into it. Seems like the current behaviour is different. Android completely zooms out, while iOS keeps its scale. |
|
Summited PR on MPAndroidChart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve added a flag (keepPositionOnRotation) to BarLineChartViewBase indicating whether the chart
should stay at its current position or not
The flag defaults to false to not change any existing behaviour.
This feature was requested/discussed in #786.
The result can be seen in the two picture pairs below:
keepPositionOnRotation = false (old behaviour):
keepPositionOnRotation = true: