add support for lineCap setting for line chart #658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user does not draw circles for line chart, the connecting dot seems not very smooth because of default lineCap.Butt
Add support for setting lineCap in this PR. I am not sure if we should put lineCapType into BarLineChartViewBase, currently combined chart and line chart will both have it.
Another thing is when I tried to port the code to drawCubic, I don't see it take effect before/after
CGPathAddCurveToPoint
, and cubic line seems smooth already, so I don't port it at last. Correct me if I am wrong.