Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for lineCap setting for line chart #658

Merged
merged 2 commits into from
Mar 17, 2016

Conversation

liuxuan30
Copy link
Member

If user does not draw circles for line chart, the connecting dot seems not very smooth because of default lineCap.Butt
Add support for setting lineCap in this PR. I am not sure if we should put lineCapType into BarLineChartViewBase, currently combined chart and line chart will both have it.

Another thing is when I tried to port the code to drawCubic, I don't see it take effect before/after CGPathAddCurveToPoint, and cubic line seems smooth already, so I don't port it at last. Correct me if I am wrong.

@danielgindi
Copy link
Collaborator

It seems like you've introduced duplicate properties...
Also properties of the line I think should be in the data and not in the provider - so you don't have to look around to find line properties scattered across the library :-)

@liuxuan30
Copy link
Member Author

For duplicated properties you mean in combined chart and line chart both have lineCapType? Or the other PR about axis line cap 719?
putting into data class seems easier and can solve the dup, I did think about it, but at that time what I think is something like line property may not be proper to be included in data class.

@liuxuan30 liuxuan30 force-pushed the lineCap branch 2 times, most recently from 2d8782c to dffe8dc Compare February 24, 2016 03:05
@liuxuan30
Copy link
Member Author

update to latest interfaces. putting lineCapType into ILineChartDataSet

@liuxuan30 liuxuan30 changed the title add support for lineCap setting for line chart and combined chart add support for lineCap setting for line chart Feb 24, 2016
@danielgindi danielgindi merged commit 6e9f64b into ChartsOrg:master Mar 17, 2016
@liuxuan30 liuxuan30 deleted the lineCap branch April 1, 2016 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants