Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing images for bar chart tests #635

Merged
merged 3 commits into from
Dec 30, 2015
Merged

Add missing images for bar chart tests #635

merged 3 commits into from
Dec 30, 2015

Conversation

pmairoldi
Copy link
Collaborator

I noticed that there was missing images for 64 bit @3x and 32 bit @2x causing the tests to fail when I would run them.

@yas375
Copy link
Contributor

yas375 commented Dec 29, 2015

From looking at generated images testHideLeftAxis, testHideLeftAxisGridlines, testHideRightAxis, testHideRightAxisGridlines I wonder if those tests are actually work as expected? Those images seem to be equivalent to me while I was expecting some changes on them. Or am I missing some details?

@pmairoldi
Copy link
Collaborator Author

No they are correct it is just the names that are confusing. testHideLeftAxis for example just hides the line that borders the graph. I'll update the tests to make more logical sense.

@yas375
Copy link
Contributor

yas375 commented Dec 29, 2015

OIC. Thanks!

danielgindi added a commit that referenced this pull request Dec 30, 2015
Add missing images for bar chart tests
@danielgindi danielgindi merged commit a972c08 into master Dec 30, 2015
@danielgindi danielgindi deleted the fix-tests branch January 17, 2016 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants