Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approved, pending styling: Fix Scroll issue when the graph is in a UITableView #464

Merged
merged 1 commit into from
Oct 30, 2015

Conversation

coupgar
Copy link

@coupgar coupgar commented Oct 12, 2015

foundScrollView will be UITableWrepperView Not UITableView, which will cause TableView Scroll issue

@danielgindi
Copy link
Collaborator

Nice catch!
Although this PR is mis-styled...
Please clean it up, match the code styling of the project, squash everything together and then we'll merge ;-)

@danielgindi danielgindi changed the title Fix Scroll issue when the graph is in a UITableView Approved, pending styling: Fix Scroll issue when the graph is in a UITableView Oct 13, 2015
@danielgindi
Copy link
Collaborator

Although, wouldn't we want to check for the specific case of UITableViewWrapperView via the class name? or does this apply to all UITableViews which are wrapped in UIScrollViews?

@coupgar
Copy link
Author

coupgar commented Oct 14, 2015

I was worried that Apple won't be happy if we use UITableViewWrapperView class name to check this case.
I will take the advice and update the pull request. :-)

@pmairoldi
Copy link
Collaborator

I don't think referencing a non public class is ideal if it works with UIScrillView. Is there scrolling issues within a collection view?

@coupgar
Copy link
Author

coupgar commented Oct 14, 2015

Actually you cannot scroll up/down when the chart view is in a UITableView, Collection View has not been tested @petester42

@pmairoldi
Copy link
Collaborator

In that case I would assume that it would be the same for any subclass of UIScrollView such as UITableView and UICollectionView. Its worth to try it out to see.

@danielgindi
Copy link
Collaborator

danielgindi commented Oct 14, 2015 via email

@coupgar
Copy link
Author

coupgar commented Oct 29, 2015

@petester42 This hack only happens in a UITableView. UICollectionView does not have a WrepperView, so it works fine with ColloctionView.

@pmairoldi
Copy link
Collaborator

I just tested this and the fix works for UITableView. Without it the chart does not behave like if it was in a scrollview.

@danielgindi
Copy link
Collaborator

@petester42 👍 to the use of where here :-)

@danielgindi
Copy link
Collaborator

@coupgar could you please squash everything together?

@coupgar coupgar force-pushed the feature/tableview_hack branch from 915fc9a to f026302 Compare October 30, 2015 10:34
pmairoldi added a commit that referenced this pull request Oct 30, 2015
Approved, pending styling: Fix Scroll issue when the graph is in a UITableView
@pmairoldi pmairoldi merged commit 530cbab into ChartsOrg:master Oct 30, 2015
@pmairoldi
Copy link
Collaborator

awesome thanks!

@coupgar coupgar deleted the feature/tableview_hack branch November 3, 2015 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants