-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Approved, pending styling: Fix Scroll issue when the graph is in a UITableView #464
Conversation
Nice catch! |
Although, wouldn't we want to check for the specific case of |
I was worried that Apple won't be happy if we use |
I don't think referencing a non public class is ideal if it works with UIScrillView. Is there scrolling issues within a collection view? |
Actually you cannot scroll up/down when the chart view is in a |
In that case I would assume that it would be the same for any subclass of |
I know that inside a UIScrollView works, haven't tested UITableView.
It should be tested to make sure that this commit handles these cases
properly
|
@petester42 This hack only happens in a |
I just tested this and the fix works for UITableView. Without it the chart does not behave like if it was in a scrollview. |
@petester42 👍 to the use of |
@coupgar could you please squash everything together? |
915fc9a
to
f026302
Compare
Approved, pending styling: Fix Scroll issue when the graph is in a UITableView
awesome thanks! |
foundScrollView will be UITableWrepperView Not UITableView, which will cause TableView Scroll issue