Fix AxisBase Formatter Getter (Fixes #4365) #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where if you overrode the formatter it didn't matter because a new one would just replace it.
|
@liuxuan30 Would you mind reviewing (or adding someone to review) this? |
|
can you give some context why this change? e.g. If you set the formatter first, the old should work. |
|
I am a little confused by what you're asking for. |
|
Ah at first I mean I didn't clearly see why old code not work. but in your case, are you saying that when you have a formatter and meet the condition, it will create a new one, so some of your properties will be lost? is this correct? |
liuxuan30
approved these changes
Jun 22, 2020
mosaic-engineering
pushed a commit
to mosaic-io/Charts
that referenced
this pull request
Dec 3, 2020
Fix AxisBase Formatter Getter (Fixes ChartsOrg#4365)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where if you overrode the
formatter it didn't matter because a new one would
just replace it.
Issue Link #4365