Algorithm updates #3638
Merged
Algorithm updates #3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjatie
force-pushed
the
algorithm-updates
branch
from
cdf5fd6 to
30595e4
Compare
|
May take longer to dig. I remember when Swift 1.2/2.2 was there, the performance is bad. So @danielgindi choose to write our own? |
liuxuan30
reviewed
Sep 19, 2018
jjatie
force-pushed
the
algorithm-updates
branch
from
89bb04b to
57bb7a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
==========================================
- Coverage 32.64% 32.61% -0.03%
==========================================
Files 114 114
Lines 10625 10625
==========================================
- Hits 3468 3465 -3
- Misses 7157 7160 +3
Continue to review full report at Codecov.
|
|
@jjatie 3.3 is just released :) I think we can focus on 4.0 now. So much in plate 😂 |
jjatie
force-pushed
the
algorithm-updates
branch
from
b14b75d to
2e95133
Compare
abhiramvadlapatla
pushed a commit
to abhiramvadlapatla/Charts
that referenced
this pull request
Dec 21, 2021
* algorithm updates * Minor code org updates * Relocated util file * Removed duplicated file akjflkajfljk
zebraciam
added a commit
to zebraciam/Charts
that referenced
this pull request
Jul 6, 2022
* master: update changelog. Fixed incorrect guard return statement when rendering limit lines (ChartsOrg#4563) Fix bounds checks on binary search (ChartsOrg#4577) Added SPM build action (ChartsOrg#4576) Replace FBSnapshotTestCase with pointfree/swift-snapshot-testing (ChartsOrg#4574) Import swift algorithms (ChartsOrg#4497) ChartViewBase cleanup (ChartsOrg#4537) SPM GitHub Action (ChartsOrg#4553) Algorithm updates (ChartsOrg#3638) Added SPM Install section Update README.md Fix missing drawIconsEnabled parameter initialization in the copying constructor of the ChartBaseDataSet (ChartsOrg#4424) Resolve conflict for 4.0 branch and master (ChartsOrg#4456) Alternative for SPM dynamic linking (ChartsOrg#4478) 3.6.0 changelog # Conflicts: # Source/Charts/Renderers/LineChartRenderer.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Inspired by WWDC'18 Embracing Algorithms
Charts relies heavily on custom algorithm implementations. Many of these are common algorithms and should instead rely on the built in implementations. In this PR I have updated the obvious candidates.
I have intentionally omitted the longer algorithms as some A) are unique algorithms and B) can become much simpler with some additional changes in the framework (i.e.
Collectionconformances introduced in 4.0.0).