Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Package Manager support. #2950

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Conversation

BrianDoig
Copy link

This implements #753 by adding a Package.swift file.

@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #2950 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2950   +/-   ##
=======================================
  Coverage   19.64%   19.64%           
=======================================
  Files         113      113           
  Lines       13792    13792           
=======================================
  Hits         2709     2709           
  Misses      11083    11083

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbdaa6...9b9dd68. Read the comment docs.

@liuxuan30
Copy link
Member

liuxuan30 commented Nov 6, 2017

seems fine comparing to https://swift.org/package-manager/#example-usage. @petester42 or swift experts?

@doofyus
Copy link

doofyus commented Nov 7, 2017

Could this please be merged in.

@liuxuan30
Copy link
Member

I will merge.

@liuxuan30 liuxuan30 merged commit a1811c7 into ChartsOrg:master Nov 8, 2017
@danielgindi
Copy link
Collaborator

Cool :-)

@pmairoldi
Copy link
Collaborator

What about the dependency on UIKit/AppKit? Is there a way to identify that this will only work on Mac and if you have the sdk installed?

@pmairoldi
Copy link
Collaborator

@doofyus could you elaborate what you needed this for? I was asked a question about spm support and from what I know about spm it can’t be used with apps right now.

@doofyus
Copy link

doofyus commented May 25, 2018

It's true that SPM is a bit limited currently, but it can be used to keep the dependencies up to date and with some workarounds, it's possible to use them in an app as well (i use SPM in a couple of them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants