Update Travis config for Xcode 8.3 and fix test failures #2378

liuxuan30 · 2017-04-20T02:09:50Z

update device id in Travis CI and xcode 8.3 image

pmairoldi · 2017-04-20T02:16:24Z

Rakefile

@@ -39,8 +39,8 @@ def devices
  {
    iOS: {
      sdk: 'iphonesimulator',
-      device: "id='22FA2149-1241-469C-BF6D-462D3837DB72'",
-      uuid: '22FA2149-1241-469C-BF6D-462D3837DB72'
+      device: "34FA4749-C467-4D45-9F8E-E31AEDDC39C2'",


The id=' is needed here.

liuxuan30 · 2017-04-20T02:27:07Z

@petester42 I guess we need to use Xcode 8.3 image as well? What else to we have to modify? I can do it all in one. Just found what you did for Xcode 8.2: 99e9aa0

But I'm not sure if I just change osx_image: xcode8.2 to xcode8.3 is enough? I saw you update xcodeproj as well.

pmairoldi · 2017-04-20T02:28:01Z

ya. just change the config to be 8.3

liuxuan30 · 2017-04-20T02:30:34Z

OK, I have changed to 8.3. Let's see if it can pass

2. use Apple TV 1080p (10.2) and iPhone 7 (10.3) device id in Travis CI

liuxuan30 · 2017-04-20T03:03:18Z

▸ Processing Info.plist

▸ Touching ChartsTests.xctest

▸ Signing /Users/travis/Library/Developer/Xcode/DerivedData/Charts-dsitxzqjkujfnvaoreewgudaitlo/Build/Intermediates/CodeCoverage/Products/Debug-iphonesimulator/ChartsTests.xctest

2017-04-20 02:46:56.978 xcodebuild[4087:13500] Error Domain=IDETestOperationsObserverErrorDomain Code=6 "Early unexpected exit, operation never finished bootstrapping - no restart will be attempted" UserInfo={NSLocalizedDescription=Early unexpected exit, operation never finished bootstrapping - no restart will be attempted}

Testing failed:

	Test target ChartsTests encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted)

** TEST FAILED **

I tried on my machine with rake ci[iOS], it has same error code, and I also checked the log:

106 11:00:46.292 xcodebuild[82088:12196011] Tracking pid 82380 for simulator <DVTiPhoneSimulator: 0x7fb8ca6c5d80> {
107         SimDevice: SimDevice : iPhone 7 (1A98B8F5-C2C4-451B-B4C0-4FC506ACC3D6) : state={ Booted } deviceType={ SimDeviceType : com.apple.        CoreSimulator.SimDeviceType.iPhone-7 } runtime={ SimRuntime : 10.3 (14E269) - com.apple.CoreSimulator.SimRuntime.iOS-10-3 }
108 }
109 11:00:46.292 xcodebuild[82088:12196011] Checking to see if pid 82380 is valid: kill(pid, 0) = 0 (YES, it's still running)
110 11:00:46.292 xcodebuild[82088:12196011] Setting up DVTTaskNotifyOnProcDeath for pid 82380
111 11:00:46.292 xcodebuild[82088:12190492] Test process runnable PID is 82380.
112 11:00:46.507 xcodebuild[82088:12190492] Got death notice for pid 82380, removing from SimulatorSessionMap
113 11:00:46.507 xcodebuild[82088:12196014] 1A98B8F5-C2C4-451B-B4C0-4FC506ACC3D6: Executable terminated at path: /Applications/Xcode.app/            Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Agents/xctest (status = 20992)
114 11:00:46.508 xcodebuild[82088:12190492] Test operation failure: Launch session expired before checking in.
115 11:00:46.509 xcodebuild[82088:12190492] _finishWithError:Error Domain=IDETestOperationsObserverErrorDomain Code=5 "Launch session expired        before checking in." UserInfo={NSLocalizedDescription=Launch session expired before checking in.} didCancel: 1

Any idea? @petester42 I googled but can't find the exact error code solution

pmairoldi · 2017-04-20T03:04:47Z

I don't have time right now but I'll look at it maybe tomorrow

liuxuan30 · 2017-04-20T03:55:19Z

Sure. I also tried to manually run

xcodebuild -project 'Charts.xcodeproj' -scheme 'ChartsTests' -configuration 'Debug' -sdk iphonesimulator -destination id='E40B5365-EF82-430D-A767-2A37995CCEE1' clean build test

on my machine, it reports:

  /bin/sh -c /Users/xuanliu/Library/Developer/Xcode/DerivedData/Charts-ambsdrskvocwekcmoobyhanaiixm/Build/Intermediates/CodeCoverage/Intermediates/Charts.build/Debug-iphonesimulator/ChartsTests.build/Script-064DBAE11D93813D002584CD.sh
Depencies have already been built.

2017-04-20 11:53:08.710 xctest[87783:12569635] The bundle “ChartsTests” couldn’t be loaded because it is damaged or missing necessary resources. Try reinstalling the bundle.
2017-04-20 11:53:08.711 xctest[87783:12569635] (dlopen_preflight(/Users/xuanliu/Library/Developer/Xcode/DerivedData/Charts-ambsdrskvocwekcmoobyhanaiixm/Build/Intermediates/CodeCoverage/Products/Debug-iphonesimulator/ChartsTests.xctest/ChartsTests): Library not loaded: @rpath/FBSnapshotTestCase.framework/FBSnapshotTestCase
  Referenced from: /Users/xuanliu/Library/Developer/Xcode/DerivedData/Charts-ambsdrskvocwekcmoobyhanaiixm/Build/Intermediates/CodeCoverage/Products/Debug-iphonesimulator/ChartsTests.xctest/ChartsTests
  Reason: image not found)
2017-04-20 11:53:08.725 xcodebuild[87517:12565751] Error Domain=IDETestOperationsObserverErrorDomain Code=6 "Early unexpected exit, operation never finished bootstrapping - no restart will be attempted" UserInfo={NSLocalizedDescription=Early unexpected exit, operation never finished bootstrapping - no restart will be attempted}
2017-04-20 11:53:08.726 xcodebuild[87517:12567557] Connection peer refused channel request for "dtxproxy:XCTestManager_IDEInterface:XCTestManager_DaemonConnectionInterface"; channel canceled <DTXChannel: 0x7fba8660af50>

Testing failed:
	Test target ChartsTests encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted)
** TEST FAILED **

Not sure if it's related. I tried to link the framework in ChartTests build phases, but no luck.

liuxuan30 · 2017-04-21T03:21:39Z

Today, I just tried to manually copy FBSnapshotTestCase.framework into

/Users/xuanliu/Library/Developer/Xcode/DerivedData/Charts-ambsdrskvocwekcmoobyhanaiixm/Build/Intermediates/CodeCoverage/Products/Debug-iphonesimulator

xuanliu:Debug-iphonesimulator xuanliu$ ls -l
total 0
drwxr-xr-x  7 xuanliu  staff  238 Apr 21 11:18 Charts.framework
drwxr-xr-x  4 xuanliu  staff  136 Apr 21 11:18 ChartsTests.swiftmodule
drwxr-xr-x  8 xuanliu  staff  272 Apr 21 11:18 ChartsTests.xctest
drwxr-xr-x  8 xuanliu  staff  272 Apr 21 11:16 FBSnapshotTestCase.framework

and just call

xcodebuild -project 'Charts.xcodeproj' -scheme 'ChartsTests' -configuration 'Debug' -sdk iphonesimulator -destination id='E40B5365-EF82-430D-A767-2A37995CCEE1' test

It actually succeeded. Still investigating why it did not copy the framework

…k for ChartsTests

codecov-io · 2017-04-21T05:42:18Z

Codecov Report

❗ No coverage uploaded for pull request base (master@aca0491). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2378   +/-   ##
=========================================
  Coverage          ?   19.66%           
=========================================
  Files             ?      112           
  Lines             ?    13710           
  Branches          ?        0           
=========================================
  Hits              ?     2696           
  Misses            ?    11014           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca0491...8302817. Read the comment docs.

liuxuan30 · 2017-04-21T05:44:26Z

Finally all green. @petester42 if the new commits of this PR looks good to you, I will merge it.

One shortage is, as $PLATFORM is determined in Travis, when we want to run tests on local machine, we have to manually run export PLATFORM=iOS

We can move $PLATFORM to Rakefile, and later export it again. Sounds not worthy.

Or, we build all schemes in the beginning. But I remember you used to build them all, and you just changed to dynamic building, must be some reasons, like Realm took too long? Since we removed Realm, building two schemes should not take much time.

Let me know what you think.

The run script is referred from Carthage instructions https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos and https://github.com/Carthage/Carthage#adding-frameworks-to-unit-tests-or-a-framework

update the schemes so test and library are linked (⌘ + U). move coping dependencies to external script like ChartsRealm

update schemes, move script to file like ChartsRealm

liuxuan30 · 2017-04-24T02:07:22Z

scripts/copy-carthage-frameworks.sh

+for (( n = 0; n < SCRIPT_INPUT_FILE_COUNT; n++ )); do
+    VAR=SCRIPT_INPUT_FILE_$n
+    source=${!VAR}.dSYM
+    dest=${BUILT_PRODUCTS_DIR}/$(basename "$source")


BTW, @petester42 which dSYM is here? and what's for? carthage copy-framework seems will copy FBSnapshotTestCase.framework.dSYM under CodeCoverage/Products/Debug-iphonesimulator/

liuxuan30 · 2017-04-25T01:36:09Z

@petester42 sorry to bring this up again, don't know why but I notice travis will compile Charts twice, but on my machine, it seems just once.

Do you think we can change clean build test to just clean test?

Update Travis config for Xcode 8.3 and fix test failures

liuxuan30 requested a review from pmairoldi April 20, 2017 02:09

liuxuan30 mentioned this pull request Apr 20, 2017

Compatibility with swift playgrounds #2335

Merged

liuxuan30 removed the request for review from pmairoldi April 20, 2017 02:10

liuxuan30 force-pushed the travis branch from a2ac5cb to 464f521 Compare April 20, 2017 02:15

pmairoldi requested changes Apr 20, 2017

View reviewed changes

pmairoldi approved these changes Apr 20, 2017

View reviewed changes

liuxuan30 force-pushed the travis branch from d69f729 to 5e73bcb Compare April 20, 2017 02:27

liuxuan30 force-pushed the travis branch from 5e73bcb to a6fd824 Compare April 20, 2017 02:29

liuxuan30 changed the title ~~use iPhone 7 10.2 device id in Travis CI~~ Update Xcode 8.3 and device id in Travis CI Apr 20, 2017

1. use xcode 8.3 image

faefe1c

2. use Apple TV 1080p (10.2) and iPhone 7 (10.3) device id in Travis CI

liuxuan30 force-pushed the travis branch from a6fd824 to faefe1c Compare April 20, 2017 02:40

liuxuan30 force-pushed the travis branch 4 times, most recently from c346d52 to 0191044 Compare April 21, 2017 05:25

use name instead of uuid, add run script for copying missing framewor…

f4d6b64

…k for ChartsTests

liuxuan30 force-pushed the travis branch from 0191044 to f4d6b64 Compare April 21, 2017 05:34

liuxuan30 changed the title ~~Update Xcode 8.3 and device id in Travis CI~~ Update Travis config for Xcode 8.3 and fix test failures Apr 21, 2017

pmairoldi and others added 2 commits April 23, 2017 20:31

update schemes, move script to file like ChartsRealm

aafc428

update the schemes so test and library are linked (⌘ + U). move coping dependencies to external script like ChartsRealm

Merge pull request #1 from danielgindi/pr/2378

8302817

update schemes, move script to file like ChartsRealm

liuxuan30 commented Apr 24, 2017

View reviewed changes

liuxuan30 merged commit 2ceffe6 into ChartsOrg:master Apr 24, 2017

liuxuan30 deleted the travis branch April 24, 2017 02:11

PeterSrost pushed a commit to sokol8/Charts that referenced this pull request Oct 31, 2018

Merge pull request ChartsOrg#2378 from liuxuan30/travis

3d79709

Update Travis config for Xcode 8.3 and fix test failures

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Travis config for Xcode 8.3 and fix test failures #2378

Update Travis config for Xcode 8.3 and fix test failures #2378

liuxuan30 commented Apr 20, 2017 •

edited

Loading

pmairoldi Apr 20, 2017

liuxuan30 Apr 20, 2017

liuxuan30 commented Apr 20, 2017

pmairoldi commented Apr 20, 2017

liuxuan30 commented Apr 20, 2017

liuxuan30 commented Apr 20, 2017

pmairoldi commented Apr 20, 2017

liuxuan30 commented Apr 20, 2017

liuxuan30 commented Apr 21, 2017 •

edited

Loading

codecov-io commented Apr 21, 2017 •

edited

Loading

liuxuan30 commented Apr 21, 2017 •

edited

Loading

liuxuan30 Apr 24, 2017 •

edited

Loading

liuxuan30 commented Apr 25, 2017

Update Travis config for Xcode 8.3 and fix test failures #2378

Update Travis config for Xcode 8.3 and fix test failures #2378

Conversation

liuxuan30 commented Apr 20, 2017 • edited Loading

pmairoldi Apr 20, 2017

Choose a reason for hiding this comment

liuxuan30 Apr 20, 2017

Choose a reason for hiding this comment

liuxuan30 commented Apr 20, 2017

pmairoldi commented Apr 20, 2017

liuxuan30 commented Apr 20, 2017

liuxuan30 commented Apr 20, 2017

pmairoldi commented Apr 20, 2017

liuxuan30 commented Apr 20, 2017

liuxuan30 commented Apr 21, 2017 • edited Loading

codecov-io commented Apr 21, 2017 • edited Loading

Codecov Report

liuxuan30 commented Apr 21, 2017 • edited Loading

liuxuan30 Apr 24, 2017 • edited Loading

Choose a reason for hiding this comment

liuxuan30 commented Apr 25, 2017

liuxuan30 commented Apr 20, 2017 •

edited

Loading

liuxuan30 commented Apr 21, 2017 •

edited

Loading

codecov-io commented Apr 21, 2017 •

edited

Loading

liuxuan30 commented Apr 21, 2017 •

edited

Loading

liuxuan30 Apr 24, 2017 •

edited

Loading