Fix Simple Bar Chart Demo, switch use of x and y values #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I saw bar chart behaves weird, and just came across this PR! |
Neral
pushed a commit
to Neral/Charts
that referenced
this pull request
Apr 24, 2017
…l/update_upstream * commit '04c5820a6cca34b98cb48b8baab1dd44f44e857d': (61 commits) add switch for clearing `lastHighlighted` in clear() (ChartsOrg#2355) update schemes, move script to file like ChartsRealm use name instead of uuid, add run script for copying missing framework for ChartsTests 1. use xcode 8.3 image 2. use Apple TV 1080p (10.2) and iPhone 7 (10.3) device id in Travis CI Fix Simple Bar Chart Demo, switch use of x and y values (ChartsOrg#2365) Converted swift 3.0 DBL_MIN leftover Removed leftover script from the combined Realm era Removed leftover scheme v3.0.2 Removed unrequited script gitignore updates Added @discardableResult to silence warnings when it’s safe to ignore result Moved Realm stuff to https://github.com/danielgindi/ChartsRealm Remove line width minimum constraint Updated build-dependencies.sh loosen realm version requirement fix Xcode 8.3 compiler warnings fix ChartsOrg#2222 move default backgroundColor to initialize() as initWithCoder also needs it Updated to use Realm version 2.4.3 Consider _yAxis.isDrawLimitLinesBehindDataEnabled for radar chart ... # Conflicts: # Source/ChartsRealm/Data/RealmBarDataSet.swift
Neral
pushed a commit
to Neral/Charts
that referenced
this pull request
Apr 24, 2017
…l/update_upstream * commit '04c5820a6cca34b98cb48b8baab1dd44f44e857d': (61 commits) add switch for clearing `lastHighlighted` in clear() (ChartsOrg#2355) update schemes, move script to file like ChartsRealm use name instead of uuid, add run script for copying missing framework for ChartsTests 1. use xcode 8.3 image 2. use Apple TV 1080p (10.2) and iPhone 7 (10.3) device id in Travis CI Fix Simple Bar Chart Demo, switch use of x and y values (ChartsOrg#2365) Converted swift 3.0 DBL_MIN leftover Removed leftover script from the combined Realm era Removed leftover scheme v3.0.2 Removed unrequited script gitignore updates Added @discardableResult to silence warnings when it’s safe to ignore result Moved Realm stuff to https://github.com/danielgindi/ChartsRealm Remove line width minimum constraint Updated build-dependencies.sh loosen realm version requirement fix Xcode 8.3 compiler warnings fix ChartsOrg#2222 move default backgroundColor to initialize() as initWithCoder also needs it Updated to use Realm version 2.4.3 Consider _yAxis.isDrawLimitLinesBehindDataEnabled for radar chart ... # Conflicts: # Source/ChartsRealm/Data/RealmBarDataSet.swift
PeterSrost
pushed a commit
to sokol8/Charts
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo broke in the following commit fbba515
The x and y values were switched.