Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChartDataSet's entryCount computed property raises a signal when _yVals is nil #631

Closed
aarondaub opened this issue Dec 29, 2015 · 0 comments
Closed

ChartDataSet's entryCount computed property raises a signal when _yVals is nil #631

aarondaub opened this issue Dec 29, 2015 · 0 comments

Comments

@aarondaub
Copy link

To reproduce:

let dataSet = ChartDataSet()
dataSet.entryCount

Expected Behaviour
entryCount returns 0

Current Behaviour
entryCount raises a signal
aarondaub pushed a commit to aarondaub/ios-charts that referenced this issue Dec 29, 2015
Use nil coalescing in ChartDataSet's entryCount (Fixes ChartsOrg#631)…
cceff42 
…\n\nThe force unwrapping in entryCount caused a crash when yVals was nil. Now entryCount returns 0.
@aarondaub aarondaub mentioned this issue Dec 29, 2015
Merged
danielgindi added a commit that referenced this issue Dec 30, 2015
@danielgindi
Merge pull request #632 from aarondaub/ad-nilCoalesceEntryCount
da03c94 
Use nil coalescing in ChartDataSet's entryCount (Fixes #631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aarondaub