-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Colors Should Support Dark Mode [iOS 13] #4133
Comments
a pull request is always wanted! |
Those merged commits are very important now since Apple announced that they won't keep apps that don't compile with iOS 13.0 SDK. |
I meant that those changes aren’t “released” yet in a new version |
I pushed a new version. I personally suggest if you like to try new stuff, use swift package or carthage, not relying on we build it for pods |
What did you do?
ℹ Run project in Xcode 11, on a iOS 13 device.
What did you expect to happen?
ℹ Black text should invert to white (i.e. Charts should use
UIColor.label
instead ofUIColor.black
).What happened instead?
ℹ Black text remains black.
Charts Environment
Charts version/Branch/Commit Number: 3.2.1
Xcode version: 11.0
Swift version: 4
Platform(s) running Charts: iOS
macOS version running Xcode: 10.14.4
The text was updated successfully, but these errors were encountered: