Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable Accessibility support? #3782

Closed
mecid opened this issue Dec 13, 2018 · 10 comments
Closed

How to disable Accessibility support? #3782

mecid opened this issue Dec 13, 2018 · 10 comments

Comments

@mecid
Copy link

mecid commented Dec 13, 2018

I would like to disable Accessibility support because it overrides my own implementation.
Is it possible?

@liuxuan30
Copy link
Member

I don't know what you mean by it overrides my own implementation? If you had your own, it should be override by yours actually.

@mecid
Copy link
Author

mecid commented Dec 29, 2018

@liuxuan30 I mean, when I use code like this it is not working now. Chart still use own implementation, but it works with the previous release.

screen shot 2018-12-29 at 21 48 30

@liuxuan30
Copy link
Member

are you able to find what's the difference?

@liuxuan30
Copy link
Member

We had a bug fix for Accessibility, but not likely to impact your saying.

@mecid
Copy link
Author

mecid commented Jan 4, 2019

@liuxuan30 your current implementation of Accessibility is too general and not working for every case. We have to be able to customize it or override.

@liuxuan30
Copy link
Member

@mecid your saying

Chart still use own implementation, but it works with the previous release.

is kind of vague, I don't remember what change could lead to this. since you have the right code here, I'm asking you to help identify what is changed

@mecid
Copy link
Author

mecid commented Jan 8, 2019

@liuxuan30 it was broken after 2.3 release, when you introduce Accesssibility support out of the box.
I can't override your implementation with my own.

@liuxuan30
Copy link
Member

What function you cannot override. I cannot find your setupDetailed...

@mecid
Copy link
Author

mecid commented Jan 11, 2019

@liuxuan30 this is my extension func, which sets accessibilityElements on ChartView. But it is not working since 2.3.

@liuxuan30
Copy link
Member

liuxuan30 commented Jan 14, 2019

you have to check out latest master branch to see what's broken then.

We are not responsible for your extension func. If there is a conflict, you should fix it. If it's the library bug, you are welcome to fix it as well, or point it out what's the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants