Bar Chart Drawing is wrong without setting axisminimum

[laurentmorvillier]

What did you do?

Hello, I've built the following graph using iOS Charts and this dataset:

Here is what I get with my current code:

The selection selects the correct value but all bars have the same size

What did you expect to happen?

Now if I add the following line:
self.leftAxis.axisMinimum = -1140.0

The chart is correctly drawn:

Are we expected to dynamically set the axisMinimum at all times? Graphs with positive and negative are correctly drawn, but it looks like positive only dataset or negative only datasets requires an axisMinimum.

Charts Environment

Charts version/Branch/Commit Number: 3.2.1
Xcode version: 10
Swift version: 4.2
Platform(s) running Charts:
macOS version running Xcode:

[zhihengcheung]

the demo don’t set axisMinimum is ok.i copy demo into my project, it dosen’t work,i don’t understand

[zhihengcheung]

i found solution，copy demo charts source cover your project source,it,ok

[laurentmorvillier]

I reproduce the issue in AnotherBarChartViewController, project attached

func setDataCount(_ count: Int, range: Double) {
    
    var yVals: [BarChartDataEntry] = []
    let values: [Double] = [-90, -700, -130, -150, -565, -550, -1140]
    for (i, v) in values.enumerated() {
        yVals.append(BarChartDataEntry(x: Double(i), y: v))
    }

// let yVals = (0..<count).map { (i) -> BarChartDataEntry in
// let mult = range + 1
// let val = Double(arc4random_uniform(UInt32(mult))) + mult/3
// return BarChartDataEntry(x: Double(i), y: val)
// }

ChartsDemo-iOS.zip

[liuxuan30]

this should be tested already with recent fix. have you called chartView.dataSetChanged after you call self.leftAxis.axisMinimum = -1140.0?

[liuxuan30]

sorry it's a bit confusing about your issue. I will take a look

[liuxuan30]

Hey, I grabbed your code from Another Bar Chart, it's drawing fine:

I guess you need to update your library. We recently had a fix about negative bars, not sure if the bug impact you as well, but currently it's drawing fine.

[laurentmorvillier]

Hey liuxuan30, thanks for your help. Updating did fix the problem!
May I ask why don't you bump the version after fixes? This could help avoiding such situation

[liuxuan30]

we had a release already. but we usually push a new version when Xcode require changes, or we had major updates. just bug fixes are not enough for a release I suppose.

[liuxuan30]

my advice would be use source code directly; it's easier to change. if you use pods or carthage, no problem, but fixing issues would be harder compared to source code. You could also point to master for carthage and pods