Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CombinedChartView's candleData don't display in v3.2.0 #3662

Closed
1 task done
Michael-Du opened this issue Sep 25, 2018 · 6 comments
Closed
1 task done

CombinedChartView's candleData don't display in v3.2.0 #3662

Michael-Du opened this issue Sep 25, 2018 · 6 comments
Assignees
@liuxuan30
Labels
bug

Comments

@Michael-Du
Copy link

Michael-Du commented Sep 25, 2018 •
edited
Loading

What did you do?

ℹ I use CombinedChartView, but candleData don't display

What did you expect to happen?

ℹ CombinedChartView's candleData display

Charts Environment

**Charts version Number:3.2.0
**Xcode version:10.0
**Swift version:4.2
**Platform(s) running Charts:iOS
**macOS version running Xcode:10.14

Demo Project

ℹI find this problem in https://github.com/danielgindi/Charts/tree/master/ChartsDemo-iOS/Swift
@tobiasbrodd
Copy link

I have the same charts environment as above and I'm also experiencing this bug when using a CombinedChartView with CandleChartData.

@liuxuan30
Copy link
Member

Are you able to reproduce with ChartsDemo?

@Michael-Du
Copy link
Author

Are you able to reproduce with ChartsDemo?

You can find this bug in your ChartsDemo
screen shot 2018-09-27 at 10 31 14 am

@vcmilani
Copy link

I have same problem here, with example and my code!

Michael-Du pushed a commit to Michael-Du/Charts that referenced this issue Sep 27, 2018
@Duke-yi
fix issue ChartsOrg#3662
26dfe03
@Michael-Du Michael-Du mentioned this issue Sep 27, 2018
Merged
@boatt
Copy link

boatt commented Sep 27, 2018

I have same problem here

@liuxuan30 liuxuan30 added the bug label Sep 28, 2018
@liuxuan30 liuxuan30 self-assigned this Sep 28, 2018
liuxuan30 added a commit that referenced this issue Oct 11, 2018
@liuxuan30
Merge pull request #3664 from Michael-Du/fix-combinedChartView-candle…
c46db9a 
…data_bug

fix issue #3662
@pmairoldi
Copy link
Collaborator

fixed by #3664

shineeth pushed a commit to shineeth/Charts that referenced this issue Oct 31, 2018
@Duke-yi
fix issue ChartsOrg#3662
205347b
mtpromano pushed a commit to MobileTradingPartnersLLP/ios-charts that referenced this issue Jan 22, 2019
Merge commit 'f2795b9813e7e8c2bcdac3f4c3cc74790116999e' into refactor…
af4e20c 
…ing/swift-4.2

* commit 'f2795b9813e7e8c2bcdac3f4c3cc74790116999e': (108 commits)
  Remove delegate method call for translation when no translation really occured
  add call chartScaled() after double tap (ChartsOrg#3770)
  fix ChartsOrg#3719
  Update README.md (ChartsOrg#3737)
  Fix applying lineCap value for line chart data sets (Fixes ChartsOrg#3739)
  Fix legend offset bug for horizontal bar chart (Fixes ChartsOrg#3301)
  Add missing properties to copy(with:) methods (ChartsOrg#3715)
  improvements in barRect height calculation  (ChartsOrg#3650)
  Remove meaningless comment
  fix wrong assignment to axisMaxLabels property
  Add missing empty line between Summary and other section manually
  fix casting warnings
  Fix guard statement format.
  Fix memory leak for macOS.
  Update ChartViewBase.swift
  bump version to 3.2.1
  close ChartsOrg#3659: fix index out of bounds issue when using stacked bar chart
  Fix memory leak after rendering
  close ChartsOrg#3661: update podspec to include swift verison
  fix issue ChartsOrg#3662
  ...

# Conflicts:
#	Charts.xcodeproj/project.pbxproj
#	ChartsDemo-iOS/ChartsDemo-iOS.xcodeproj/project.pbxproj
#	ChartsDemo-iOS/Objective-C/Demos/LineChartFilledViewController.m
#	ChartsDemo-iOS/Objective-C/Demos/RadarChartViewController.m
#	ChartsDemo-iOS/Swift/Demos/CandleStickChartViewController.swift
#	Rakefile
#	Source/Charts/Charts/BarLineChartViewBase.swift
#	Source/Charts/Charts/ChartViewBase.swift
#	Source/Charts/Charts/HorizontalBarChartView.swift
#	Source/Charts/Charts/PieChartView.swift
#	Source/Charts/Charts/RadarChartView.swift
#	Source/Charts/Components/Legend.swift
#	Source/Charts/Components/Marker.swift
#	Source/Charts/Components/YAxis.swift
#	Source/Charts/Data/Implementations/ChartBaseDataSet.swift
#	Source/Charts/Data/Implementations/Standard/ChartData.swift
#	Source/Charts/Data/Implementations/Standard/PieChartData.swift
#	Source/Charts/Data/Interfaces/ChartDataSetProtocol.swift
#	Source/Charts/Data/Interfaces/ScatterChartDataSetProtocol.swift
#	Source/Charts/Filters/DataApproximator+N.swift
#	Source/Charts/Formatters/FillFormatter.swift
#	Source/Charts/Formatters/ValueFormatter.swift
#	Source/Charts/Highlight/BarHighlighter.swift
#	Source/Charts/Highlight/ChartHighlighter.swift
#	Source/Charts/Highlight/HorizontalBarHighlighter.swift
#	Source/Charts/Renderers/AxisRendererBase.swift
#	Source/Charts/Renderers/BarChartRenderer.swift
#	Source/Charts/Renderers/BarLineScatterCandleBubbleRenderer.swift
#	Source/Charts/Renderers/BubbleChartRenderer.swift
#	Source/Charts/Renderers/CandleStickChartRenderer.swift
#	Source/Charts/Renderers/ChartDataRendererBase.swift
#	Source/Charts/Renderers/CombinedChartRenderer.swift
#	Source/Charts/Renderers/HorizontalBarChartRenderer.swift
#	Source/Charts/Renderers/LegendRenderer.swift
#	Source/Charts/Renderers/LineChartRenderer.swift
#	Source/Charts/Renderers/PieChartRenderer.swift
#	Source/Charts/Renderers/RadarChartRenderer.swift
#	Source/Charts/Renderers/Renderer.swift
#	Source/Charts/Renderers/ScatterChartRenderer.swift
#	Source/Charts/Renderers/XAxisRenderer.swift
#	Source/Charts/Renderers/XAxisRendererHorizontalBarChart.swift
#	Source/Charts/Renderers/XAxisRendererRadarChart.swift
#	Source/Charts/Renderers/YAxisRenderer.swift
#	Source/Charts/Renderers/YAxisRendererHorizontalBarChart.swift
#	Source/Charts/Renderers/YAxisRendererRadarChart.swift
#	Source/Charts/Utils/ChartUtils.swift
#	Source/Charts/Utils/ViewPortHandler.swift
#	Tests/ReferenceImages_64/ChartsTests.CombinedChartTests/[email protected]
#	Tests/ReferenceImages_64/ChartsTests.CombinedChartTests/testAllRightAxisDependency_tvOS_1920.0_1080.0.png
#	Tests/ReferenceImages_64/ChartsTests.CombinedChartTests/[email protected]
#	Tests/ReferenceImages_64/ChartsTests.CombinedChartTests/testDefaultAxisDependency_tvOS_1920.0_1080.0.png
#	Tests/ReferenceImages_64/ChartsTests.CombinedChartTests/[email protected]
#	Tests/ReferenceImages_64/ChartsTests.CombinedChartTests/testLeftRightAxisDependency_tvOS_1920.0_1080.0.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liuxuan30 liuxuan30

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pmairoldi @liuxuan30 @boatt @tobiasbrodd @Michael-Du @vcmilani