You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the stride(from:to:by) should be a stride(from:through:by) (use through, not to), like so:
openoverridefunc drawValues(context:CGContext){
//....
for j in stride(from: _xBounds.min, through:Int(ceil(Double(_xBounds.max - _xBounds.min)* phaseX + Double(_xBounds.min))), by:1){
guard let e = dataSet.entryForIndex(j)else{ break }
This edit works locally for me, I'll send a PR for the change as well here in a minute, but haven't done an extensive audit for the other chart types to see if a similar issue exists there.
The text was updated successfully, but these errors were encountered:
)
The wrong stride termination was causing us to not render the last text value.
Verified the issue in the `ChartsDemo` example, but have not looked closely
at other chart types.
This did fix the missing label, however, I found a new issue that when zoomed in, the animation on x axis is not in sync: the value text will jump out first and then come with the line. Changing back to to the animation will be good. awkward...
In 3.0 (using master from commit 3a2da1b) I'm seeing that the last y-label in my charts is not being rendered.
I've tracked down was I think is the cause to this line:
https://github.com/danielgindi/Charts/blob/a34d55a5c9d16c1f4f6f48f2148b4e88902c55d0/Source/Charts/Renderers/LineChartRenderer.swift#L552
I think the
stride(from:to:by)
should be astride(from:through:by)
(usethrough
, notto
), like so:This edit works locally for me, I'll send a PR for the change as well here in a minute, but haven't done an extensive audit for the other chart types to see if a similar issue exists there.
The text was updated successfully, but these errors were encountered: