Improve test coverage & fix exposed issues #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
===========================================
+ Coverage 20.65% 32.92% +12.27%
===========================================
Files 19 22 +3
Lines 460 489 +29
Branches 70 75 +5
===========================================
+ Hits 95 161 +66
+ Misses 353 318 -35
+ Partials 12 10 -2 ☔ View full report in Codecov by Sentry. |
…d fix issue where role was not included in filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getUsersWithRolewas ignoring the role when theNUMBER_OF_QUIZZES_COMPLETED_WITH_DESCsort option was being usedUserService.getUsersto be better typed using function overloadingOut of scope (due to be less valuable and a little more tedious):