Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make registry pull secret optional #36

Closed
danielemery opened this issue Aug 1, 2024 · 0 comments · Fixed by #37
Closed

Make registry pull secret optional #36

danielemery opened this issue Aug 1, 2024 · 0 comments · Fixed by #37
Assignees
@danielemery
Labels
enhancement New feature or request

Comments

@danielemery
Copy link
Owner

keys has been made a public Github registry. This means the imagePullSecret is no longer required for kubernetes to pull the image.

It should still be supported (in case someone still wants to use the secret to avoid any rate limits) but if it's not provided it should not be included in the deployment config.
@danielemery danielemery added the enhancement New feature or request label Aug 1, 2024
@danielemery danielemery self-assigned this Aug 1, 2024
@danielemery danielemery linked a pull request Aug 1, 2024 that will close this issue
Make registrySecretName an optional helm value (the registry is public) #37
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielemery danielemery

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make registrySecretName an optional helm value (the registry is public) danielemery/keys
1 participant
@danielemery