Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve terminology for control type #6

Open
westonruter opened this issue May 18, 2016 · 2 comments
Open

Improve terminology for control type #6

westonruter opened this issue May 18, 2016 · 2 comments

Comments

@westonruter
Copy link

Currently the Control::$type is designed to indicate whether it is a selector for a post, term, or user. However, there could very well be controls that are for editing these objects that would have these same types. I suggest that the type be fixed to something like object_multi_select and then to introduce a new class property like $selection_type to hold whether it is for a post, term, or user. And then another $selection_object to contain the kind of post or user that can be selected. (These variable names for type and object are derived from terminology used in nav menu items. Something better could be chosen.)

@westonruter
Copy link
Author

Done in xwp/wp-customize-object-selector#1

@westonruter
Copy link
Author

(Well, somewhat. No support for terms or users has been added yet.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant