After switching to PHP, the CI run is always successful, even when it should fail

[leoloso]

In this code in entrypoint.php:

exec($copyGitDirectoryCommandLine, $outputLines, $exitCode);

if ($exitCode === 1) {
    die('Command failed');
}

...the php die is only printing the message on screen, but it does not produce an exit 1, so the script still does not fail.

Demonstration:

• I created a PR in leoloso/PoP to test Fix for "Since using PHP, a git push error does not produce the run to fail" #18
• There, I'm passing the wrong credentials (https://github.com/leoloso/PoP/blob/465d9d2779781d384cfd0c709faabb4eaf44373b/.github/workflows/split_monorepo.yaml#L20-L22), so doing git push will fail
• The code fails, printing the error code (https://github.com/leoloso/PoP/pull/772/checks?check_run_id=2987635297#step:4:80)
• But the run is still successful!

I also tried executing this (https://github.com/leoloso/monorepo-split-github-action/blob/8795fc8/entrypoint.php#L98):

exec('exit ' . $exitCode);

But it also doesn't work.

[leoloso]

I searched for documentation, but didn't find anything. The GitHub Action docs only explain how to exit from entrypoint.sh.

So I have no clue how to fix this.

[Ferror]

Well there is an official js package..maybe we need something similar - https://github.com/actions/toolkit/tree/main/packages/core

[TomasVotruba]

This is rather generic Github Action issue, unrelated to this package.

If you find a better way, please send PR 👍