Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularise and refactor code base #5

Open
danger-ahead opened this issue Jun 27, 2022 · 10 comments
Open

Modularise and refactor code base #5

danger-ahead opened this issue Jun 27, 2022 · 10 comments
Assignees
Labels
easy fix Can be easily fixed good first issue Good for newcomers

Comments

@danger-ahead
Copy link
Owner

The current code base has many repeated lines. Also the general architecture isn't very modularised. Has many unnecessary parameter passes, unnecessary imports, etc.

Need to fix that. You have full freedom over how you want to achieve the end goal (that is, modularising the code base and reducing the numbers of total lines).

Let me know if you want to discuss this over a call. Will you guide you through the codebase.

@danger-ahead danger-ahead added good first issue Good for newcomers easy fix Can be easily fixed labels Jun 27, 2022
@danger-ahead danger-ahead reopened this Jun 27, 2022
@Gaurangseven
Copy link

What is the app about?

@danger-ahead
Copy link
Owner Author

What is the app about?

A portfolio template. Check Readme

@kartikver15gr8
Copy link

I would love to fix this issue

@danger-ahead
Copy link
Owner Author

I would love to fix this issue

Please go ahead.

@kartikver15gr8
Copy link

Amazing then plz tell me which codebase u want to improvise

@kartikver15gr8
Copy link

I'll refactor it and will try to make it more efficient and optimized

@danger-ahead
Copy link
Owner Author

I'll refactor it and will try to make it more efficient and optimized

This was a pretty old project of mine. You can go through the entire codebase and look for possible optimisations. Any type of contribution is welcome.

Any new design change or idea is welcome too.

@kartikver15gr8
Copy link

Awesome!!

@kartikver15gr8
Copy link

Then

@kartikver15gr8
Copy link

Hey @danger-ahead I've committed changes in index.html and style.css file
check those changes and kindly merge those into the main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy fix Can be easily fixed good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants