-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#482 #483 #491 Make word breaker testable and start writing tests. #492
Conversation
I wonder if we could do a property based test in this case (using something like junit quickcheck ). |
Plus minor behaviour change for word break method to avoid setting ends-on -soft-hyphen flag for soft hyphen at end of box.
This is to make sure infinite loop fixes do not break this functionality.
This should ensure no infinite loop bugs creep in over time.
This pr does the following:
|
I initially thought of parameter testing, but was underwhelmed by the syntax in Junit 4. After looking at the documentation of quickcheck, I probably should have used it rather than reinventing the wheel... |
We need a much more robust line breaker so any suggested unit tests will be incorporated.