Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187 Specifying default DocumentBuilderFactory implementation and add… #188

Merged

Conversation

sosnut
Copy link
Contributor

@sosnut sosnut commented Mar 28, 2018

…ing a way to bypass it

Specifying "com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl" as the default DocumentBuilderFactory, in BaseRendererBuilder. (This is the factory that is used by default, but an application may depend on an other parser which could provide an incompatible builder factory).

Adding method useDocumentBuilderFactoryImplementationClass(), to be able to use another implementation (or the DocumentBuilderFactory currently available in the application, if null is passed) if necessary.

…n and adding a way to bypass it

Specifying "com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl" as the default DocumentBuilderFactory, in BaseRendererBuilder. (This is the factory that is used by default, but an application may depend on an other parser which could provide an incompatible builder factory).

Adding method useDocumentBuilderFactoryImplementationClass(), to be able to use another implementation (or the DocumentBuilderFactory currently available in the application, if null is passed) if necessary.
@sosnut
Copy link
Contributor Author

sosnut commented Mar 28, 2018

Changes very similar to fix of #54 in a737e96

@danfickle
Copy link
Owner

Thanks @sosnut

This is excellent. Merging now.

@danfickle danfickle merged commit c399427 into danfickle:open-dev-v1 Mar 29, 2018
@sosnut
Copy link
Contributor Author

sosnut commented Apr 2, 2018

Great; thanks to you for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants