Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justified text background is rendered incorrectly #286

Closed
allartammik opened this issue Oct 16, 2018 · 3 comments
Closed

Justified text background is rendered incorrectly #286

allartammik opened this issue Oct 16, 2018 · 3 comments

Comments

@allartammik
Copy link

When text alignment is justified (text-align: justify) and background color is set (span style="background-color:#1abc9c"), the background is rendered incorrectly. I'm using version 0.0.1-RC16 of the library.

I made a simple test case for you https://bitbucket.org/allar/openhtmltopdftestcase/src/master/
I also found a closed issue #281 that might be related.

Thanks

@allartammik
Copy link
Author

Hi again!

I took the source code of latest open-dev-v1 (commit b545b1) and built the openhtmltopdf-core, and I am glad to confirm, that the fix you made with #281 works with background color as well.

I'm looking forward to the release now. Can you predict when the next release will take place?

@danfickle
Copy link
Owner

Hi, I’m planning a release for the weekend. Thanks for the test case, I’ll add it to the visual regression tests shortly.

@danfickle
Copy link
Owner

RC17 just released with fix. Thanks @allartammik, @koritakoa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants