-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/paths should 404 if there are not assets with path_prefix/ #546
Comments
Thanks Yarik, this is definitely a bug. |
This is half complete... navigating to a non-existing location shows an appropriate error message in the web app, but it implies that the folder exists and just has no files in it. We can improve the behavior to be more explicit that the path itself doesn't exist. |
indeed this was actually fixed at the level of API: ❯ curl -X GET "https://api.dandiarchive.org/api/dandisets/000003/versions/draft/assets/paths/?path_prefix=junk%2F" -H "accept: application/json"
{"detail":"Specified path not found."}% and the only remaining need here is to fix web UI -- what would that take??? |
@waxlamp any ETA for the fix for the acknowledged bug? |
Actually, API does not just return that record but also 404s:
and since web UI/files browser does return specific message of having nothing there, I think we can just consider this issue addressed |
ATM it would just happily return empty lists, and as a result web ui would just render an empty folder. Go e.g. go to https://gui.dandiarchive.org/#/dandiset/000108/draft/files?location=junk
I think it would be more appropriate for dandi-api to 404 whenever both folders and files are empty, and web ui also have some error shown in such cases.
The text was updated successfully, but these errors were encountered: