Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching of the version on DLP does not lead to switching of metadata version meditor uses #2081

Open
yarikoptic opened this issue Nov 20, 2024 · 2 comments · May be fixed by #2127
Open

Switching of the version on DLP does not lead to switching of metadata version meditor uses #2081

yarikoptic opened this issue Nov 20, 2024 · 2 comments · May be fixed by #2127
Assignees
@mvandenburgh
Labels
bug Something isn't working client/meditor Issues with the metadata editor (meditor) UX Affects usability of the system

Comments

@yarikoptic
Copy link
Member

Originally troubleshooted in

I think it might potentially lead to (meta)data loss and confusion (at least it did for me). Steps to reproduce

if you refresh the page -- url will be with the current draft version -- and open meditor, you will see updated view.
@yarikoptic yarikoptic added bug Something isn't working UX Affects usability of the system client/meditor Issues with the metadata editor (meditor) labels Nov 20, 2024
@yarikoptic
Copy link
Member Author

looking at Meditor.vue -- and given that it ends up in the same "tab" as were it was closed before, I am afraid that it just is initialized once when page loads immediately with metadata from that version and is just hidden. Then "METADATA" button just shows or hides it and nothing triggers it to reload metadata.

@waxlamp waxlamp assigned mvandenburgh and unassigned waxlamp Dec 11, 2024
@mvandenburgh
Copy link
Member

looking at Meditor.vue -- and given that it ends up in the same "tab" as were it was closed before, I am afraid that it just is initialized once when page loads immediately with metadata from that version and is just hidden. Then "METADATA" button just shows or hides it and nothing triggers it to reload metadata.

This is correct. I was able to reproduce this locally and am working on a fix

@waxlamp waxlamp mentioned this issue Dec 24, 2024
Open
@mvandenburgh mvandenburgh linked a pull request Jan 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvandenburgh mvandenburgh

Labels
bug Something isn't working client/meditor Issues with the metadata editor (meditor) UX Affects usability of the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reactivity bug in meditor dandi/dandi-archive
3 participants
@yarikoptic @waxlamp @mvandenburgh