Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crate-ize Sparse21 #20

Open
dan-fritchman opened this issue Sep 8, 2023 · 3 comments
Open

Crate-ize Sparse21 #20

dan-fritchman opened this issue Sep 8, 2023 · 3 comments

Comments

@dan-fritchman
Copy link
Owner

We would like this repository to become the source for the sparse21 crate.

This would require:

  • Pull sparse21/ up to “crate level”
  • Bring along spnum module, make it a public export from the new sparse21 crate
  • Add back all the TOML, config, docs, etc from the existing crate

Open question(s):

  • The Result/ error type(s). Currently shared between sparse21 and the rest of spice21. Either:
    • sparse21 can export one and spice21 can use it, or
    • They can both define one, with conversions there-between
@twitchyliquid64
Copy link

Do you happen to have tests/data/mat0.mat on your system? I cant run tests/solve.rs without it

@twitchyliquid64
Copy link

The Result/ error type(s). Currently shared between sparse21 and the rest of spice21.

A quick glance suggests theres only 3 or 4 actually different kinds of errors, they just happen to be strings atm. So I imagine a sparse21-specific enum as an Error type is ideal, and we can wrap that for the spice21 error type.

@dan-fritchman
Copy link
Owner Author

Sounds great!

And I think I know where to find those test files; best to shoot me an email at [email protected] in search of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants