Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producing an error when trying to load SQLite database #46

Closed
hrvyncent opened this issue Jan 27, 2024 · 9 comments
Closed

Producing an error when trying to load SQLite database #46

hrvyncent opened this issue Jan 27, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@hrvyncent
Copy link

Extension Version

v1.1.0

OS and Version

Windows 11

VS Code Version

v1.85.2

Database name and Version

Sqlite3

Steps to reproduce

Steps to reproduce the behavior:

  1. Create a new laravel application
  2. Change the DB_CONNECTION inside the .env to sqlite
  3. execute the php artisan:migrate.
  4. Open the DevDb and click the Sqlite Database File Picker.
  5. Select your database file (database.sqlite)

Expected behavior

Expected to load the tables like the screenshot
image

Screenshots

image

Additional context

No response

@hrvyncent hrvyncent added bug Something isn't working low priority unconfirmed labels Jan 27, 2024
@squpshift
Copy link

I am also experiencing this issue.

OS: Macos 13.3.1
VSCode: 1.87.0-insider

Screenshot 2024-02-02 at 11 58 12 AM

@sathyalog
Copy link

Same happening with me as well. Looks like the extension is not working in MacOS. Kindly fix this.

@damms005
Copy link
Owner

damms005 commented Feb 7, 2024

This is top of list for me.

Will update this issue asap 👍

@ehsansafari
Copy link

Extension Version
v1.3.1

OS and Version
Arch 6.7.4-arch1-1

VS Code Version
v1.86.1

Database name and Version
Sqlite3

photo_2024-02-16_15-21-08

Issue:
When clicked, vscode will be closed

@damms005
Copy link
Owner

@ehsansafari Please open a new issue to address your bug report, because to my understanding what you are experiencing is different.

The current bug we are addressing in this issue has pop-up notification which provides better context, while in your case, it is "vscode will be closed"

@avenjamin
Copy link

Just adding that I've got the same issue as @squpshift too - happy to help test.

macOS: 14.3.1 Apple Silicon/M1
VSCode: 1.86.2
DebDB: 1.3.2

dlopen(/Users/me/.vscode/extensions/damms005.devdb-1.3.2/node_modules/sqlite3/build/Release/node_sqlite3.node, 0x0001): tried: 
    '/Users/me/.vscode/extensions/damms005.devdb-1.3.2/node_modules/sqlite3/build/Release/node_sqlite3.node' (not a mach-o file),
    '/System/Volumes/Preboot/Cryptexes/OS/Users/me/.vscode/extensions/damms005.devdb-1.3.2/node_modules/sqlite3/build/Release/node_sqlite3.node' (no such file), 
    '/Users/me/.vscode/extensions/damms005.devdb-1.3.2/node_modules/sqlite3/build/Release/node_sqlite3.node' (not a mach-o file)

Note sure if it's related but node was installed via brew.
I tried npm install -g sqlite sqlite3 just in case, but that didn't help unfortunately.

Will keep digging

@damms005
Copy link
Owner

damms005 commented Feb 19, 2024

Thanks for your efforts @avenjamin

npm install -g sqlite sqlite3 won't work because the binary needs to be in the extension folder, not in a global system location

The issue is with cross-platforms deployment, given that I build and deploy from my Linux box, and it only affects SQLite databases. I am currently tracking these issues in an attempt to fix this:

There are workarounds I can release that involves user providing custom install location etc., but I want the fix to be config-free because I want to maintain a smooth DX for this extension.

For now, my next try is to switch to yarn and see if using the supportedArchitectures feature helps.

Will definitely update here when fixed.

@damms005
Copy link
Owner

Hey guys, this one took a while but finally I'm happy I've found a fix.

I should get some time this weekend to hack it out, test it, and publish an update with this fix to the marketplace.

Thanks for hanging on! 💪

@damms005
Copy link
Owner

This issue is now resolved in version v1.6.22

I had to temporarily drop support for Arm arch on Windows because getting sqlite3 native dependencies build for it requires some more time from me and I don't want that to hold this back any longer. But Intel Windows is supported.

For clarity sake, DevDb now officially supports these platforms:

  • Linux (Linux-x64, Linux-arm64, Linux-arm, Alpine-x64)
  • macOS (Darwin-x64, Darwin-arm64 Apple Silicon)
  • Windows (Win32-x64)

The REAMD file has been updated to also reflect the above.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants