Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporter doesn't save a single field change in the template #342

Open
ArekKuczynski opened this issue Feb 23, 2025 · 1 comment
Open

Reporter doesn't save a single field change in the template #342

ArekKuczynski opened this issue Feb 23, 2025 · 1 comment
Labels
potential bug Might be a bug, requires further clarification

Comments

@ArekKuczynski
Copy link
Collaborator

Describe the bug
Reporter will not save single changes in the sections. When changing one of the fields, such as Header, for example, will still be visible in the settings but will not be saved to the template unless another field is clicked or a preview is generated. The options related to clicks work without any problems and will always be saved in the template no matter what we do after changing the options in it. It seems that changing column names, title, start time, end time works well.

From quick tests, the fields that won't be saved are: Heading, Note content, Filter, custom SQL query

To Reproduce
Steps to reproduce the behavior:

  1. Open Reporter
  2. Change any Heading in one of the sections or note content, not column name (but only this field, clicking another one will save changes).
  3. Click other section in the template (this step is not required, just to be sure)
  4. Save Template
  5. Open Template
  6. See that the name of the Heading did not save.

Expected behavior
When saving the template, the template saving algorithm should recheck any additional changes in the settings.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows
  • Version Reporter v1.4.0
@ArekKuczynski ArekKuczynski added the potential bug Might be a bug, requires further clarification label Feb 23, 2025
@damies13
Copy link
Owner

Yes, You need to exit the field to trigger the save

I used to have it trigger save/refresh on update but it was causing the UI to jump around too much, after typing your change type the tab key and that will trigger the save (it triggers on field exit)

I'm not sure if I can make it any better than this for now? I'll have a think about it, and look over the code. I'll use this issue number if I make any changes to this.

If you want to try changing it back to on change, you can give it a try, but be aware of how it will impact the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential bug Might be a bug, requires further clarification
Projects
None yet
Development

No branches or pull requests

2 participants