-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable lowercase convention #130
Comments
Hi Jasper At present, I have fixed all the document properties to lowercase values in Elasticsearch. If it would help you , I could change this to allow case sensitive properties in the Elasticsearch documents. Greetings Damien |
That would definitely help!! - Currently migrating logs from mssql to elasticsearch with existing case sensitive properties created my Serilog. ElasticsearchCRUD is just so much easier to use compared to NEST ;). Thanks in advance! J. |
Hi Jasper I'll make a release in August with this change. I'll make it so that the default config is lowercase and add a code configuration property which can remove this and use case sensitive properties. Or do you have a better idea? greetings Damien |
What's the argument for defaulting to lower case? It seems a bit invasive to change the document format, when persisting to ES, merely by convention. I suspect you have implemented this, due to ES CS nature. However from a developers point of view, I would switch the behavior: by default no manipulation and a configuration to enable the lower casing of properties behavior. Just my 2 cents :) Sounds great with a pending release in Aug.! Give me a heads up, if you can't find the time and I might do a PR for whichever strategy makes most sense. Thanks J. |
Hi Jasper Makes sense, I was just thinking of the existing clients who would need to change this for existing If you have time to do a PR, it would be great, I can't do anything until the start of August and I'll implement this then. I also wanted to add some of the changes/new features from ES 1.6. Greetings Damien |
Thanks for this I'll merge this next week and create a NuGet package, Greetings Damien |
Hi
Is it possible to disable the lowercase convention on all properties, when saving new documents?
Thanks
/Jasper
The text was updated successfully, but these errors were encountered: