Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters are not visible enough #293

Closed
Krysztophe opened this issue Oct 20, 2020 · 2 comments · Fixed by #413
Closed

Filters are not visible enough #293

Krysztophe opened this issue Oct 20, 2020 · 2 comments · Fixed by #413
Labels
enhancement New feature or request

Comments

@Krysztophe
Copy link

When looking at https://explain.dalibo.com/plan/8UD, you do NOT see quickly than 2 seq scans are filtered, or that the hash join at the top if filtered too. This information is hidden in the Misc tab.

This is very important as filters are the 1st criterion to choose how to begin a plan.

Suggestions :

  • a funnel icon somewhere in the main node box (without color, as it is already used when most lines are filtered), with Filter informations in tooltip
  • a very small pie chart, somewhere in the box, indicating a crude proportion of the lines that have made it through the filter. eg: green on gray as long, with green = kept lines, with tooltip. The color (green, blue, red...) could depend on the proportion, so this pie could replace the existing funnel icon warning
  • an horizontal bar at the bottom of the node, with the same color code
  • a vertical bar along the right of the node, with the same color code
@Krysztophe Krysztophe changed the title Table filters are not visible enough Filters are not visible enough Oct 20, 2020
@pgiraud pgiraud added the enhancement New feature or request label Feb 16, 2021
pgiraud added a commit that referenced this issue Aug 4, 2021
pgiraud added a commit that referenced this issue Aug 5, 2021
pgiraud added a commit that referenced this issue Aug 6, 2021
pgiraud added a commit that referenced this issue Aug 6, 2021
@pgiraud
Copy link
Member

pgiraud commented Aug 6, 2021

I've just push commits that fix this issue. I've taken your first suggestion into account. This means that when there are rows removed by the filter a grey funnel icon appears. In cases where the execution time of the node is also significant, the funnel icon appears with a color as before.

The hovering tooltip now tells the user the percentage of rows removed.

@Krysztophe
Copy link
Author

Nice ! 👍
(Yes, I 'm a bit late)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants