Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove failure #67

Closed
aep opened this issue Dec 31, 2018 · 4 comments
Closed

remove failure #67

aep opened this issue Dec 31, 2018 · 4 comments

Comments

@aep
Copy link

aep commented Dec 31, 2018

failure doesn't work on mips because it depends on backtrace.
It looks trivial to remove, and i would just open a PR, but i'm not sure what the original intend of adding it was. Is this something that should be behind a feature flag?

@tarcieri
Copy link
Contributor

tarcieri commented Dec 31, 2018

This crate uses failure with default-features = false and therefore you shouldn't be encountering any issues related to the backtrace crate (it is an optional dependency of failure and gated on the std feature).

Can you post what error you're encountering? It looks like from https://github.com/aep/cr2/issues/1 another crate is activating the std feature of failure, in which case this is not the culprit you're looking for.

@aep
Copy link
Author

aep commented Dec 31, 2018

interesting. the other crate turns out to only have a build dependency to failure.
i wonder if that confuses cargo. will dig deeper, thanks

@tarcieri
Copy link
Contributor

tarcieri commented Dec 31, 2018

Yes, it's a known deficiency of cargo (it does not support separate dependency resolution for dev / build). See:

rust-lang/cargo#2589
rust-lang/cargo#4664
rust-lang/cargo#4866

@aep
Copy link
Author

aep commented Dec 31, 2018

Darn. will remove the other thing then to see if that makes it all work. thanks!

@aep aep closed this as completed Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants