Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChromHMM enhancer extension #68

Merged
merged 22 commits into from
Jan 24, 2024
Merged

ChromHMM enhancer extension #68

merged 22 commits into from
Jan 24, 2024

Conversation

LeonHafner
Copy link
Collaborator

@LeonHafner LeonHafner commented Dec 1, 2023

This pull request introduces the Enhancer Prediction with ChromHMM, as described in Issue #63.
The changes have not yet been tested and are not yet complete.

TODO:

  • Add better way to create the cellmarkfiletable using the input csv for ehmm
  • Add java container for BINARIZE_BAMS and LEARN_MODEL processes
  • Get parameters from the config file (organism, genome version, ...)
  • Add nf-core meta object to the input and output channels of the processes

@LeonHafner LeonHafner added the enhancement New feature or request label Dec 1, 2023
@LeonHafner LeonHafner added this to the First nextflow run for Lisa's thesis milestone Dec 1, 2023
@LeonHafner LeonHafner requested a review from nictru December 1, 2023 14:48
@LeonHafner LeonHafner self-assigned this Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@LeonHafner LeonHafner marked this pull request as draft December 1, 2023 14:48
@nictru nictru linked an issue Dec 7, 2023 that may be closed by this pull request
Copy link
Collaborator

@nictru nictru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-pasting files from another repo is not a good practice, we should do one of the following:

  • Reference files from there as Permalinks to the original repo directly in the igenomes config (preferable)
  • Add the repo as git submodule

Resulting TODO list:

  • Remove chromHMM files from this Repo
  • Add meta entries to all processes, will contain metadata from the design file (state, assay) as well as a unique id (which should be added as tag to each process)
  • Add labels to each process (important for resource allocation)
  • Add java docker images: Even if it runs on our cluster, it does not have to run on every user's system
  • I thought of something else and forgot it, will at later if it comes to my mind again

@LeonHafner
Copy link
Collaborator Author

I integrated the ChromHMM workflow into the main pipeline and testet it.
This part should be done from my side and can be merged.
Feel free to make any necessary corrections before approving the merge.

@LeonHafner LeonHafner marked this pull request as ready for review December 26, 2023 20:52
@nictru nictru self-requested a review December 28, 2023 08:24
Copy link
Collaborator

@nictru nictru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks fine, but the ChromHMM output is not yet used in any way - should clarify in today's meeting how to proceed with EHMM and than make the necessary connections

@LeonHafner
Copy link
Collaborator Author

I integrated the output of ChromHMM/Rose into the pipeline. This should finish the work on ChromHMM/Rose. Feel free to merge the PR or request further changes if needed.

@nictru nictru removed this from the First nextflow run for Lisa's thesis milestone Jan 16, 2024
@LeonHafner LeonHafner requested a review from nictru January 18, 2024 08:49
@nictru nictru merged commit a660376 into inspect Jan 24, 2024
@nictru nictru deleted the inspect-chromhmm branch January 24, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scripts for enhancer processing
2 participants