-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChromHMM enhancer extension #68
Conversation
Python linting (
|
163cd2b
to
8820918
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy-pasting files from another repo is not a good practice, we should do one of the following:
- Reference files from there as Permalinks to the original repo directly in the igenomes config (preferable)
- Add the repo as git submodule
Resulting TODO list:
- Remove chromHMM files from this Repo
- Add meta entries to all processes, will contain metadata from the design file (state, assay) as well as a unique id (which should be added as tag to each process)
- Add labels to each process (important for resource allocation)
- Add java docker images: Even if it runs on our cluster, it does not have to run on every user's system
- I thought of something else and forgot it, will at later if it comes to my mind again
I integrated the ChromHMM workflow into the main pipeline and testet it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks fine, but the ChromHMM output is not yet used in any way - should clarify in today's meeting how to proceed with EHMM and than make the necessary connections
I integrated the output of ChromHMM/Rose into the pipeline. This should finish the work on ChromHMM/Rose. Feel free to merge the PR or request further changes if needed. |
This pull request introduces the Enhancer Prediction with ChromHMM, as described in Issue #63.
The changes have not yet been tested and are not yet complete.
TODO: