Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't recognize function if the "(" written in the following lines. #10

Open
lifishake opened this issue Dec 25, 2015 · 9 comments
Open
Assignees
Labels

Comments

@lifishake
Copy link

Reports "Unknown exception" when function is following format:

void fun
(
int param
)
{
}

But when parenthesis and function in the same line, everything is OK.

void fun (
int param
)
{
}

Our strange coding standard. Please!
Thanks in advance.

@dail8859
Copy link
Owner

That is quit a strange format. :) Should be an easy fix when I get time next week to check it out.

@dail8859 dail8859 self-assigned this Dec 28, 2015
@dail8859 dail8859 added the bug label Dec 28, 2015
@dail8859
Copy link
Owner

So it looks like there is a bug in the regular expression engine DoxyIt is using. I don't plan on digging into the regular expression parser either. So this might take a while to fix...

@lifishake
Copy link
Author

It's ok. Not a serious problem, there is no pressing needs.

@chcg
Copy link
Contributor

chcg commented Feb 7, 2017

Maybe changing from trex to c++11 std::regex might solve the issue, if it is really in the regex engine itself, but that would require a major rework and check if current features are supported by std::regex.

@dail8859
Copy link
Owner

dail8859 commented Feb 7, 2017

I had looked at this at one point but due to the static linking, the DLL size went up quite a bit from what I remember. This specific issues is a bit of a odd case. If the trex code had more issues I'd probably switch to something else but I'm not too worried about it currently.

@chcg
Copy link
Contributor

chcg commented Feb 7, 2017

Likely that the std::regex is much bigger than trex.

Maybe it is worth mentioning in the readme.md that a modified version 1.3 is used of trex as the version info is not part of the trex.h or .cpp.

@dail8859
Copy link
Owner

dail8859 commented Feb 7, 2017

Likely that the std::regex is much bigger than trex.

Oh I'm sure it is. I went with trex because it was simple and small.

Maybe it is worth mentioning in the readme.md that a modified version 1.3 is used of trex as the version info is not part of the trex.h or .cpp.

I'm not sure what it would benefit really. And if I recall it's not like I had to make major changes to it.

@chcg
Copy link
Contributor

chcg commented Feb 7, 2017

Nice to know if somebody like me having a look at the open\fixed bugs of trex, if the one mentioned here is a known or new one.

@dail8859
Copy link
Owner

dail8859 commented Feb 7, 2017

If the trex library was active and being updated I do see how that could help. AFAICT it has been abandoned for years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants