feat: client side redirects #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Would you open a new discussion to discuss possible approaches? |
Done! |
pmelab
force-pushed
the
client-side-redirects
branch
from
162332d
to
5892e4a
Compare
pmelab
force-pushed
the
client-side-redirects
branch
from
c9c055e
to
0a350e4
Compare
dai-shi
reviewed
Oct 3, 2024
README.md
Outdated
| @@ -545,6 +545,88 @@ export const Component = () => { | |||
| }; | |||
| ``` | |||
|
|
|||
| ### Redirects | |||
There was a problem hiding this comment.
We carefully design and write our README (which will be on the website).
Can you write it down in docs instead for now?
dai-shi
approved these changes
Oct 4, 2024
|
|
||
| Redirects are not handled by Waku directly. Instead, you can use either a custom middleware or the hosting environment to achieve that. The `<Link />` component does not deal with redirects either and will by default show the **404** page instead. To resolve this, you have to add an additional redirect for each redirected path, that points Waku to the correct `RSC` file. If there is a redirect from `/old` to `/new`, there also has to be one from `/RSC/old.txt`` to `/RSC/new.txt`to make the `<Link />` component`s smooth page transition work. | ||
|
|
||
| > The `/RSC/` file naming convention is [subject to change](https://github.com/dai-shi/waku/discussions/929#discussioncomment-10825975) in future versions of Waku. |
There was a problem hiding this comment.
I'm going to change it in the next patch version. 😝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #929