feat: enable compression #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Hi, can you add the PR description with some details? |
Merged
|
Thanks for the suggestion! |
dai-shi
requested changes
Sep 26, 2024
packages/waku/src/cli.ts
Outdated
| @@ -144,6 +145,7 @@ async function runStart() { | |||
| import(pathToFileURL(path.resolve(distDir, DIST_ENTRIES_JS)).toString()); | |||
| const app = new Hono(); | |||
| app.use(contextStorage()); | |||
| app.use(compress()) | |||
There was a problem hiding this comment.
It looks like a good addition, it's not 100% certain if this won't cause any issues for all users.
So, my suggestion is to introduce a new option --experimental-compress and use it explicitly.
We can also enable it for the dev server too.
dai-shi
approved these changes
Sep 26, 2024
dai-shi
added a commit
that referenced
this pull request
Oct 7, 2024
Description meta tags used in the scaffolded apps is wrong as per Google Light House. `<meta property="description" content="The minimal React framework" />` Should be `<meta name="description" content="The minimal React framework" />` This along with #903 gives perfect light house score Co-authored-by: daishi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text compression is not enabled in hono.
When we run a light house score on the sample app generated, we get 95 score.
Enabling compression along with the meta description fix in #904 gives 100/100.