hot reloading doesn't work even in the reference example

[dannylin108]

I used npm create waku@latest reference example, but hot reloading of client component doesn't work..

This is the repo https://stackblitz.com/~/github.com/dannylin108/waku-starter

vokoscreenNG-2024-11-25_16-07-04.mp4

[dai-shi]

Thanks for reporting.

It can repro with stackblitz sandbox too: https://stackblitz.com/edit/github-hwngcz?file=src%2Fcomponents%2Fcounter.tsx,src%2Fpages%2Findex.tsx

It seems to work with the local machine, so this looks like an issue with StackBlitz. I think it worked once at some point with StackBlitz.
I need someone to help looking into this.

[dai-shi]

Works: https://stackblitz.com/github/dai-shi/waku/tree/v0.21.2/examples/01_template?file=src%2Fcomponents%2Fcounter.tsx

Breaks: https://stackblitz.com/github/dai-shi/waku/tree/v0.21.3/examples/01_template?file=src%2Fcomponents%2Fcounter.tsx

So, it looks like a regression with v0.21.3.

[dai-shi]

v0.21.2...v0.21.3
there are so many commits.

[dai-shi]

working v0.21.2 + #935: breaks
working v0.21.2 + #932: breaks
working v0.21.2 + #925: breaks
working v0.21.2 + #919: breaks
working v0.21.2 + #903: works
working v0.21.2 + #901: works
working v0.21.2 + #916: works
working v0.21.2 + #918: breaks

that's impossible. #918 doesn't change anything. 😕

c110fe1...74c5a6b actually includes #886?

working v0.21.2 + #886: breaks
working v0.21.2 + #914: works

34d2c08...20a4dfc should include the regression.

I think it's #886. Can @tylersayshi look into it please?

[dai-shi]

It seems to work with the local machine

That's my oversight. It looked working, but it wasn't hot reload. It was force reload. It still behaves different for me from the StackBlitz case.

[dai-shi]

I'm not exactly sure with the StackBlitz case specifically, but #1021 should fix general cases.