Add support for libreoffice #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some changes pending that heavily modifies how unoconv looks for binaries, and an attempt to restart itself using the OpenOffice/LibreOffice supplied python binary. But since I don't trust this implementation yet, it has not been merged. But those changes also implement LibreOffice. I'll pull this for now, but expect a redesign :-) |
|
Yes, a redesign sounds like a good idea, adding more stuff to the list did seem like the wrong approach :-) Good to hear you are working on that. |
|
The new code has been tested (on Linux) and committed in the master branch. Works very well with LibreOffice 3.4.3 ! If you are using unoconv I am interested to hear your feedback. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like several, if not all, distributions are switching to libreoffice, from openoffice. Unfortunately this means that the search paths are going to be different. The attached commit fixed things for me, but it probably makes sense to change this in a more comprehensive way.
Other than the path unoconv seems to work fine with libreoffice 3.3.1.