-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Tests for helm chart & some fixes for found issues #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1752 +/- ##
==========================================
+ Coverage 89.68% 89.74% +0.06%
==========================================
Files 271 271
Lines 8993 8993
==========================================
+ Hits 8065 8071 +6
+ Misses 687 684 -3
+ Partials 241 238 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
closes #1717
Checklist
Description
Implementation of unit tests for the helm chart.
During the course of this work, the following issues were identified and resolved:
heimdall/templates/deployment.yaml:28:22: executing "heimdall/templates/deployment.yaml" at <.Values.deployment.annotations>: nil pointer evaluating interface {}.deployment
. This was due to a copy-paste mistake in the template’s annotation access definition within thewith
clause. Instead of correctly using.
to reference the current context,.Values.deployment.annotations
was incorrectly used within the nested template.rules
property. However, the configuration for the admission controller (validating webhook) in the helm chart was not updated accordingly, and the helm chart still expected its configuration to be under therules
property.namespaceSelector
, causing them to be ignored by the Kubernetes server API.Changelist