-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DISCUSSION] Run monitor in a thread executor #137
Comments
I made the monitor a completely separate entity primarily to facilitate debugging. For example, if the kernel gets locked up or some task runs away forever, the monitor can still operate and (potentially) show some useful information about what is happening. There's definitely a bit of encapsulation being violated. But hopefully it's for a good cause ;-) |
I think running it in a thread pool executor forever until the kernel shuts down should have the same effect, shouldn't it? Other than that, I cat't imagine how to properly terminate the monitor if it's being run in a thread executor, so probably this is not so good idea :) |
Closing for now. All improvements to the monitor welcome though. |
Recently I got obsessed by the idea to pull monitoring into the kernel space. What I mean is to me it looks like the monitor thread is a bit of an external interaction with a kernel, which somewhat violates the main principle of curio to restrict any external interaction with a kernel.
So I'm wondering if this makes sense to launch the monitoring server as a task in a thread pool executor. With this we will reuse the curio task management system to supervise the monitor just as any other task. Or am I just trying to overcomplicate what already works fine?
The text was updated successfully, but these errors were encountered: