-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making code blocks in line with custom page color #512
Comments
Will this use pure CSS, or some variables? How much does it complicate the code? |
Pure CSS. Originally my ambition was to shrink the code while adding support, but it turns out some extra style overriding was needed to overcome existing table styles in Here is the PoC; if it's ok I can submit a PR very soon. |
Now it is possible to try some bg colors from nav bar. |
That looks good. Although I don't think the javascript in navbar items is something that needs to be shown, as cool as it is :) |
The nav bar javascript is only a one-off hack for you to check out a few color combinations 😄 |
Recently I'm working on some changes to simplify code block styles and allow them to blend in more nicely with custom page background color (through more extensive use of transparency). Would such changes be welcome, or @daattali you would prefer styles staying as-is? About elements with hardcoded color, tables and code blocks come into mind, there are probably other as well. In the case of code block, I mean something like the following instead of hardcoding gray shades in code block background:
The text was updated successfully, but these errors were encountered: