Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making code blocks in line with custom page color #512

Closed
abelcheung opened this issue Jul 3, 2019 · 5 comments · Fixed by #516
Closed

Making code blocks in line with custom page color #512

abelcheung opened this issue Jul 3, 2019 · 5 comments · Fixed by #516

Comments

@abelcheung
Copy link
Contributor

abelcheung commented Jul 3, 2019

Recently I'm working on some changes to simplify code block styles and allow them to blend in more nicely with custom page background color (through more extensive use of transparency). Would such changes be welcome, or @daattali you would prefer styles staying as-is? About elements with hardcoded color, tables and code blocks come into mind, there are probably other as well. In the case of code block, I mean something like the following instead of hardcoding gray shades in code block background:

Clipboard02

image

image

@daattali
Copy link
Owner

daattali commented Jul 3, 2019

Will this use pure CSS, or some variables? How much does it complicate the code?

@abelcheung
Copy link
Contributor Author

Pure CSS. Originally my ambition was to shrink the code while adding support, but it turns out some extra style overriding was needed to overcome existing table styles in main.css, so the complexity stays more or less the same right now. Hopefully those overriding can be removed later when tackling table style later on.

Here is the PoC; if it's ok I can submit a PR very soon.

@abelcheung abelcheung changed the title Making some elements in line with custom page color Making code blocks in line with custom page color Jul 4, 2019
@abelcheung
Copy link
Contributor Author

Now it is possible to try some bg colors from nav bar.

@daattali
Copy link
Owner

daattali commented Jul 4, 2019

That looks good. Although I don't think the javascript in navbar items is something that needs to be shown, as cool as it is :)

@abelcheung
Copy link
Contributor Author

The nav bar javascript is only a one-off hack for you to check out a few color combinations 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants