Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should it be possible to resize the window with "set columns"? #156

Open
a-torgovitsky opened this issue Nov 3, 2018 · 8 comments · May be fixed by #264 or Lyude/neovim-gtk#2
Open

Should it be possible to resize the window with "set columns"? #156

a-torgovitsky opened this issue Nov 3, 2018 · 8 comments · May be fixed by #264 or Lyude/neovim-gtk#2

Comments

@a-torgovitsky
Copy link

On gvim:
set columns = 50
resizes a window

This also works in terminal nvim (using gnome terminal).

However, this doesn't work for me in neovim-gtk.
If the new number of columns is smaller than the old number, then the window stays the same size, but the "editor space" gets reduced.
If the new number of columns is larger than the old number, then nothing appears to happen.
Is that expected? If so, is there a different command I should be using?

In case it is not expected, here is my system info:

  • OS: Linux Mint Cinnamon 19
  • Neovim version: 0.2.2
  • Neovim-Gtk build version: commit f4c2b2c from October 25th
@bk2204
Copy link

bk2204 commented Jul 15, 2021

I'd also like this feature, except with lines. With gvim, I normally set a 24-character height by default but have a mapping to expand it to the full height of the screen by setting lines. Any other way to do this would also be fine; I'm not picky. I used the latest HEAD on Debian sid/amd64.

jacobmischka added a commit to jacobmischka/neovim-gtk that referenced this issue Jul 15, 2021
@jacobmischka
Listen to VimResized event and resize the window when needed
142de5c 
Fixes daa84#156
@jacobmischka jacobmischka linked a pull request Jul 15, 2021 that will close this issue
Open
@jacobmischka
Copy link
Contributor

I believe I implemented this here, would appreciate if you gave it a shot and let me know if it works how you expect: https://github.com/jacobmischka/neovim-gtk/tree/handle-resize

@bk2204
Copy link

bk2204 commented Jul 15, 2021

Yeah, that looks great. It seems to do everything I want.

I appreciate the quick patch; I had planned to look at this this weekend, but now I don't have to.

@jacobmischka
Copy link
Contributor

Great!

jacobmischka added a commit to jacobmischka/neovim-gtk that referenced this issue Jul 16, 2021
@jacobmischka
Listen to VimResized event and resize the window when needed
5451b59 
Fixes daa84#156
jacobmischka added a commit to jacobmischka/neovim-gtk that referenced this issue Jul 16, 2021
@jacobmischka
Listen to VimResized event and resize the window when needed
30d6802 
Fixes daa84#156
@jacobmischka
Copy link
Contributor

Just a heads up if you're using that branch in the meantime: I force pushed after realizing I could move some borrows and clones after the checks. Sorry!

jacobmischka added a commit to jacobmischka/neovim-gtk that referenced this issue Jul 16, 2021
@jacobmischka
Listen to VimResized event and resize the window when needed
038a4c9 
Fixes daa84#156
jacobmischka added a commit to jacobmischka/neovim-gtk that referenced this issue Aug 7, 2021
@jacobmischka
Listen to VimResized event and resize the window when needed
3963695 
Fixes daa84#156
@bk2204
Copy link

bk2204 commented Aug 14, 2021

This is working pretty well for me. @jacobmischka, would you be willing to open a pull request? It would be great to get this incorporated in the main version.

@jacobmischka
Copy link
Contributor

I did a month ago #264

@bk2204
Copy link

bk2204 commented Aug 14, 2021

Ah, my apologies. I missed that.

jacobmischka added a commit to jacobmischka/neovim-gtk that referenced this issue Oct 12, 2021
@jacobmischka
Listen to VimResized event and resize the window when needed
1354d49 
Fixes daa84#156
jacobmischka added a commit to jacobmischka/neovim-gtk that referenced this issue Oct 17, 2021
@jacobmischka
Listen to VimResized event and resize the window when needed
dbe9a93 
Fixes daa84#156
jacobmischka added a commit to jacobmischka/neovim-gtk that referenced this issue Oct 17, 2021
@jacobmischka
Listen to VimResized event and resize the window when needed
28b2dc8 
Fixes daa84#156
@jacobmischka jacobmischka linked a pull request Oct 17, 2021 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bk2204 @jacobmischka @a-torgovitsky