Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing react-hot-loader #132

Closed
d4rkr00t opened this issue Nov 26, 2016 · 1 comment
Closed

Consider removing react-hot-loader #132

d4rkr00t opened this issue Nov 26, 2016 · 1 comment
Labels

Comments

@d4rkr00t
Copy link
Owner

d4rkr00t commented Nov 26, 2016

As I mentioned here 203ad3a. Sometime react-hot-loader causes some errors in Aik.

For release 0.13 I had to fix few of them and it led to support only react 15.4+ for -r option.

Some related issues:

At the moment Aik uses [email protected]. I thought about upgrading to v3. Which is currently in beta. But if I do so, everyone will have to configure hot loader like this (example from RHL 3 docs):

import React from 'react'
import ReactDOM from 'react-dom'
import { AppContainer } from 'react-hot-loader'
import App from './containers/App'

ReactDOM.render(
  <AppContainer>
    <App/>
  </AppContainer>,
  document.getElementById('root')
);

// Hot Module Replacement API
if (module.hot) {
  module.hot.accept('./containers/App', () => {
    const NextApp = require('./containers/App').default;
    ReactDOM.render(
      <AppContainer>
        <NextApp/>
      </AppContainer>,
      document.getElementById('root')
    );
  });
}

More on this here: https://github.com/gaearon/react-hot-loader/tree/next-docs/docs#migration-to-30

Even though it's great tool if it continues to deliver issues into Aik I'll have to remove it.

@d4rkr00t
Copy link
Owner Author

d4rkr00t commented Feb 5, 2017

That will fix #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant