Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader errors with latest version of Silent's Crosstone #18

Closed
rskskr opened this issue Nov 27, 2022 · 2 comments
Closed

Shader errors with latest version of Silent's Crosstone #18

rskskr opened this issue Nov 27, 2022 · 2 comments

Comments

@rskskr
Copy link

rskskr commented Nov 27, 2022

The latest release of Silent's Crosstone (still on the testing branch for now) is yielding errors that visually look similar to issue #5 with stair-stepped shadows. This is when running the optimizer with the same settings as before, with only merging different materials checked, along with same dimension textures.

Unity_nDQhpnYq6a

The Unity console shares these errors with me:

Unity_zNxVq4V1CI

And the offending generated shaders:

shaders.zip

@rskskr
Copy link
Author

rskskr commented Nov 30, 2022

This has since been fixed (unintentionally) in an update of the shader!

@rskskr rskskr closed this as completed Nov 30, 2022
@d4rkc0d3r
Copy link
Owner

It wasn't unintentionally!

Anyways I'll reopen this since I haven't fixed it on my end. The issue comes from applying all keywords to all passes even if the pass doesn't have the corresponding shader feature pragmas.

@d4rkc0d3r d4rkc0d3r reopened this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants