Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep in sync with JSON5 improvements? #17

Open
brettz9 opened this issue Nov 4, 2019 · 4 comments
Open

Keep in sync with JSON5 improvements? #17

brettz9 opened this issue Nov 4, 2019 · 4 comments

Comments

@brettz9
Copy link
Contributor

brettz9 commented Nov 4, 2019

Hi,

I like the additions you've made, particularly the backtick support, and was wondering if you might be able to resync with the improvements since added to JSON5. (I'm particularly interested in an ESM export, but it seems other improvements or fixes have since been made.)

If this is too much work to keep up with, would recommending an extension mechanism to JSON5 help?

Thanks!

@d3x0r
Copy link
Owner

d3x0r commented Nov 4, 2019

Sure, I'll look into that.

@d3x0r
Copy link
Owner

d3x0r commented Nov 4, 2019

I've updated the git repository to include new rollup scripts associated with JSON5...
There's a few things I'd like to check before publishing to NPM.

Published 1.0.3 on NPM.
... there's no such thing as -NaN, if it was not a number, it can't be +/-, huh? ... shrug

@d3x0r
Copy link
Owner

d3x0r commented Nov 4, 2019

I don't know that the names and things are exported correctly for the new outputs... they kinda look right but I don't know.... if you can provide feedback it'd be appreciated

@brettz9
Copy link
Contributor Author

brettz9 commented Nov 4, 2019

Looks all good to me... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants