This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Switch default appid port to 9091. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brndnmtthws
force-pushed
the
default-appid-port-9091
branch
2 times, most recently
from
a74bd7e to
af7d843
Compare
Using port 81 by default is difficult because it's a privileged port. Also added it back on by default, now that we're not binding to a privileged port.
brndnmtthws
force-pushed
the
default-appid-port-9091
branch
from
af7d843 to
406b86c
Compare
|
Thanks for heads up! We're defaulting to using static service ports for now, as good as vhosts look on paper, the issue is that you need to create DNS records to go along the task/app vhost. |
|
Just FYI, this should not affect vhosts. It only affects things which use the magic |
brndnmtthws
added a commit
that referenced
this pull request
Nov 20, 2015
Switch default appid port to 9091.
|
Oh right, misread, carry on 😇 |
manriquecms
added a commit
to manriquecms/marathon-lb
that referenced
this pull request
Feb 22, 2018
* Fix isolate failed backends when regenerating config * Update changelog
manriquecms
added a commit
to manriquecms/marathon-lb
that referenced
this pull request
Feb 22, 2018
* Fix isolate failed backends when regenerating config * Update changelog
manriquecms
added a commit
to manriquecms/marathon-lb
that referenced
this pull request
Feb 22, 2018
d2iq-archive#28) * Fix isolate failed backends when regenerating config * Update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using port 81 by default is difficult because it's a privileged port.
Also added it back on by default, now that we're not binding to a
privileged port.
cc @felixb @scalp42