From c195c679ddd15142cb10c933c3eafefd2ad3833e Mon Sep 17 00:00:00 2001 From: d-m-u Date: Tue, 25 Sep 2018 15:12:23 -0400 Subject: [PATCH] Remove todo with virtual attr inclusion in attr list --- app/models/service_retire_task.rb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/models/service_retire_task.rb b/app/models/service_retire_task.rb index ce7b2f8f1f4..c3b6bf6aaf5 100644 --- a/app/models/service_retire_task.rb +++ b/app/models/service_retire_task.rb @@ -35,10 +35,7 @@ def create_retire_subtasks(parent_service, parent_task) # (https://github.com/ManageIQ/manageiq/blob/3921e87915b5a69937b9d4a70bb24ab71b97c165/app/models/service_template/filter.rb#L5) # which should be extended to retirement as part of later work # svc_rsc.resource_type != "ServiceTemplate" || self.class.include_service_template?(self, srr.id, parent_service) - - # TODO: use changes here: https://github.com/ManageIQ/manageiq/pull/17996 to not have to filter by col_names - # 17996 removes virtual attributes from @attrs list - nh = attributes.slice(*self.class.column_names).except!("id", "created_on", "updated_on", "type", "state", "status", "message") + nh = attributes.except("id", "created_on", "updated_on", "type", "state", "status", "message") nh['options'] = options.except(:child_tasks) # Initial Options[:dialog] to an empty hash so we do not pass down dialog values to child services tasks nh['options'][:dialog] = {}