Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(card): add support for Switch #63

Merged
merged 5 commits into from
Oct 7, 2021
Merged

feat(card): add support for Switch #63

merged 5 commits into from
Oct 7, 2021

Conversation

minajevs
Copy link
Contributor

@minajevs minajevs commented Oct 7, 2021

Closes #52

@aloisdg aloisdg added enhancement New feature or request hacktoberfest hacktoberfest-accepted A pull request is considered approved once it has an overall approving review from maintainers, or h labels Oct 7, 2021
@aloisdg aloisdg added this to the v1 milestone Oct 7, 2021
aloisdg
aloisdg approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@aloisdg aloisdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

aloisdg
aloisdg suggested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@aloisdg aloisdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw a small error. Switch card doesn't have the length 17. Could you add an enum From16To19Skip17 and use it?

type From16To19Skip17 =
    | Random = 0
    | Sixteen = 16
    | Eighteen = 18
    | Nineteen = 19

Thanks again

@minajevs
Copy link
Contributor Author

minajevs commented Oct 7, 2021

Just saw a small error. Switch card doesn't have the length 17. Could you add an enum From16To19Skip17 and use it?

type From16To19Skip17 =
    | Random = 0
    | Sixteen = 16
    | Eighteen = 18
    | Nineteen = 19

Thanks again

Oh no..., my bad, will do now

@minajevs minajevs requested a review from aloisdg October 7, 2021 12:46
aloisdg
aloisdg approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@aloisdg aloisdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@aloisdg aloisdg merged commit fda668d into d-edge:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloisdg aloisdg aloisdg approved these changes

Assignees

@minajevs minajevs

Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted A pull request is considered approved once it has an overall approving review from maintainers, or h
Projects
None yet
Milestone
v1
Development

Successfully merging this pull request may close these issues.

Add support for card Switch
2 participants
@minajevs @aloisdg