Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong filenames for Linux builds #2

Open
probonopd opened this issue Dec 28, 2018 · 4 comments
Open

Wrong filenames for Linux builds #2

probonopd opened this issue Dec 28, 2018 · 4 comments

Comments

@probonopd
Copy link

https://github.com/d-baranowski/dnd-character-sheet/releases has wrong filenames for Linux builds. Possibly productName needs to be set.
@d-baranowski
Copy link
Owner

What's the recommended naming convention?

@probonopd
Copy link
Author

probonopd commented Dec 29, 2018 •
edited
Loading

CharacterSheet-0.1.8-x86_64.AppImage (the application name should be like on the Mac, and -$VERSION-x86_64.AppImage appended).

@d-baranowski
Copy link
Owner

I have changed the app name now the names will be more consistent. Are these filenames correct:
dnd-character-sheet_0.1.8_amd64.deb
dnd-character-sheet-0.1.8-x86_64.AppImage

@probonopd
Copy link
Author

...almost:
CharacterSheet-0.1.8-x86_64.AppImage would be correct.

Reference:
electron-userland/electron-builder#775

@d-baranowski d-baranowski reopened this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@probonopd @d-baranowski