Storing credentials in Keychain #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be an issue on Xcode Server where the migration tests seem to be hanging. My guess is that it's a hanging keychain issue. TODO: investigate whether to not use a fake keychain object for tests |
czechboy0
changed the title
Result of Integration 2Duration: 14 minutes and 51 seconds |
Result of Integration 3Duration: 14 minutes and 38 seconds |
… in tests - was hanging when ran on CI
Result of Integration 4Duration: 3 minutes and 49 seconds |
czechboy0
added a commit
that referenced
this pull request
Jan 23, 2016
[WIP] Storing credentials in Keychain
czechboy0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137, #202.
Uses KeychainAccess wrapped in SwiftSafe to make it thread-safe. Works nicely.